Skip to content

ARROW-17675: [C++] Modified the FileSource::Equals method to handle the case where buffer_ is null #14085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lidavidm merged 2 commits into from
Sep 10, 2022
Merged

ARROW-17675: [C++] Modified the FileSource::Equals method to handle the case where buffer_ is null #14085

lidavidm merged 2 commits into from
Sep 10, 2022

Conversation

@westonpace
Copy link
Member

@westonpace westonpace commented Sep 9, 2022

No description provided.

@westonpace
Copy link
Member Author

westonpace commented Sep 9, 2022

See https://github.com/apache/arrow/runs/8264940145?check_suite_focus=true

@westonpace westonpace requested a review from lidavidm September 9, 2022 16:26
lidavidm
lidavidm approved these changes Sep 9, 2022
View reviewed changes
@vibhatha
Copy link
Contributor

vibhatha commented Sep 10, 2022

@westonpace thanks for fixing this one 👍

@lidavidm lidavidm changed the title MINOR: [C++] Modified the FileSource::Equals method to handle the case where buffer_ is null ARROW-17675: [C++] Modified the FileSource::Equals method to handle the case where buffer_ is null Sep 10, 2022
@lidavidm
Copy link
Member

lidavidm commented Sep 10, 2022

I ended up making a JIRA when I saw this elsewhere without realizing so I linked them

@github-actions
Copy link

github-actions bot commented Sep 10, 2022

https://issues.apache.org/jira/browse/ARROW-17675

@github-actions
Copy link

github-actions bot commented Sep 10, 2022

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

@lidavidm
Copy link
Member

lidavidm commented Sep 10, 2022

All failures are being fixed/tracked elsewhere

@lidavidm lidavidm merged commit a63e60b into apache:master Sep 10, 2022
@ursabot
Copy link

ursabot commented Sep 11, 2022

Benchmark runs are scheduled for baseline = 8a9037d and contender = a63e60b. a63e60b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.2% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.92% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] a63e60ba ec2-t3-xlarge-us-east-2
[Failed] a63e60ba test-mac-arm
[Failed] a63e60ba ursa-i9-9960x
[Finished] a63e60ba ursa-thinkcentre-m75q
[Finished] 8a9037d4 ec2-t3-xlarge-us-east-2
[Failed] 8a9037d4 test-mac-arm
[Failed] 8a9037d4 ursa-i9-9960x
[Finished] 8a9037d4 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@westonpace @zagto
ARROW-17675: [C++] Modified the FileSource::Equals method to handle t…
303c759 
…he case where buffer_ is null (apache#14085)

Authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: David Li <li.davidm96@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lidavidm lidavidm lidavidm approved these changes

Assignees

No one assigned

Labels

Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@westonpace @vibhatha @lidavidm @ursabot