Skip to content

ARROW-17673: [R] desc in dplyr::arrange should allow dplyr:: prefix #14090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nealrichardson merged 2 commits into from
Sep 15, 2022
Merged

ARROW-17673: [R] desc in dplyr::arrange should allow dplyr:: prefix #14090

nealrichardson merged 2 commits into from
Sep 15, 2022

Conversation

@eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Sep 10, 2022

No description provided.

@eitsupi
allow dplyr::desc
ec6f2dc 
Signed-off-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
@eitsupi
add tests
f6019fb 
Signed-off-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
@github-actions
Copy link

github-actions bot commented Sep 10, 2022

https://issues.apache.org/jira/browse/ARROW-17673

@eitsupi eitsupi mentioned this pull request Sep 12, 2022
Merged
@nealrichardson nealrichardson merged commit 5c773bb into apache:master Sep 15, 2022
@eitsupi eitsupi deleted the r-desc-dplyr-prefix branch September 15, 2022 22:28
@ursabot
Copy link

ursabot commented Sep 16, 2022

Benchmark runs are scheduled for baseline = d8f64ee and contender = 5c773bb. 5c773bb is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.37% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.28% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.07% ⬆️0.04%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 5c773bb9 ec2-t3-xlarge-us-east-2
[Failed] 5c773bb9 test-mac-arm
[Failed] 5c773bb9 ursa-i9-9960x
[Finished] 5c773bb9 ursa-thinkcentre-m75q
[Finished] d8f64eec ec2-t3-xlarge-us-east-2
[Finished] d8f64eec test-mac-arm
[Failed] d8f64eec ursa-i9-9960x
[Finished] d8f64eec ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
@eitsupi @zagto
ARROW-17673: [R] desc in dplyr::arrange should allow dplyr:: pr…
7eb6744 
…efix (apache#14090)

Authored-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nealrichardson nealrichardson nealrichardson approved these changes

Assignees

No one assigned

Labels

Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eitsupi @ursabot @nealrichardson