Skip to content

Conversation

@eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Sep 10, 2022

The rlang::quo function used in lines added in PR #13786 (d5f80cb) but not imported.

mtcars |> arrow::arrow_table() |> dplyr::mutate(dplyr::across(starts_with("c"), as.character)) |> dplyr::collect()
#> Error in quo(!!call2(.x, sym(.y))) : could not find function "quo"

@nealrichardson
Copy link
Member

It sounds like you've hit a case that's not covered in the test suite? Can you add a test that is fixed by this change?

@eitsupi
Copy link
Contributor Author

eitsupi commented Sep 17, 2022

It sounds like you've hit a case that's not covered in the test suite? Can you add a test that is fixed by this change?

The reason this error does not occur in the current test is that this error does not occur when dplyr is loaded.
It seems to stop loading dplyr on all files to detect this in the tests...
(I wondered if lintr could detect such cases, but apparently it cannot.)

reprex on 02b24f7

fn <- \() mtcars |> arrow::arrow_table() |> dplyr::mutate(dplyr::across(starts_with("c"), as.character)) |> head() |> dplyr::collect()
fn()
#> Error in quo(!!call2(.x, sym(.y))): could not find function "quo"
library(dplyr, warn.conflicts = FALSE)
fn()
#>    mpg cyl disp  hp drat    wt  qsec vs am gear carb
#> 1 21.0   6  160 110 3.90 2.620 16.46  0  1    4    4
#> 2 21.0   6  160 110 3.90 2.875 17.02  0  1    4    4
#> 3 22.8   4  108  93 3.85 2.320 18.61  1  1    4    1
#> 4 21.4   6  258 110 3.08 3.215 19.44  1  0    3    1
#> 5 18.7   8  360 175 3.15 3.440 17.02  0  0    3    2
#> 6 18.1   6  225 105 2.76 3.460 20.22  1  0    3    1

Created on 2022-09-17 with reprex v2.0.2

Signed-off-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
@nealrichardson
Copy link
Member

Ah ok, got it. I just rebased, will merge when CI passes. Thanks for catching this.

@nealrichardson nealrichardson merged commit 7a56846 into apache:master Sep 27, 2022
@eitsupi eitsupi deleted the r-missing-quo-func branch September 27, 2022 16:34
@ursabot
Copy link

ursabot commented Sep 28, 2022

Benchmark runs are scheduled for baseline = 7a3d801 and contender = 7a56846. 7a56846 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.38% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.27% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.21% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 7a568468 ec2-t3-xlarge-us-east-2
[Failed] 7a568468 test-mac-arm
[Failed] 7a568468 ursa-i9-9960x
[Finished] 7a568468 ursa-thinkcentre-m75q
[Finished] 7a3d8010 ec2-t3-xlarge-us-east-2
[Finished] 7a3d8010 test-mac-arm
[Failed] 7a3d8010 ursa-i9-9960x
[Finished] 7a3d8010 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants