Skip to content

ARROW-17690: [R] Implement dplyr::across() inside distinct() #14154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nealrichardson merged 1 commit into from
Sep 20, 2022
Merged

ARROW-17690: [R] Implement dplyr::across() inside distinct() #14154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion r/R/dplyr-funcs-doc.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@
#'
#' ## dplyr
#'
#' * [`across()`][dplyr::across()]: supported inside `mutate()`, `summarize()`, `group_by()`, and `arrange()`;
#' * [`across()`][dplyr::across()]: not yet supported inside `filter()`;
#' purrr-style lambda functions
#' and use of `where()` selection helper not yet supported
#' * [`between()`][dplyr::between()]
Expand Down
4 changes: 2 additions & 2 deletions r/data-raw/docgen.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,8 @@ docs <- arrow:::.cache$docs

# across() is handled by manipulating the quosures, not by nse_funcs
docs[["dplyr::across"]] <- c(
# TODO(ARROW-17387, ARROW-17389, ARROW-17390): other verbs
"supported inside `mutate()`, `summarize()`, `group_by()`, and `arrange()`;",
# TODO(ARROW-17387): do filter
"not yet supported inside `filter()`;",
# TODO(ARROW-17366): do ~
"purrr-style lambda functions",
# TODO(ARROW-17384): implement where
Expand Down
2 changes: 1 addition & 1 deletion r/man/acero.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions r/tests/testthat/test-dplyr-distinct.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,16 @@ test_that("distinct() can contain expressions", {
)
})

test_that("across() works in distinct()", {
compare_dplyr_binding(
.input %>%
distinct(across(starts_with("d"))) %>%
collect() %>%
arrange(dbl, dbl2),
tbl
)
})

test_that("distinct() can return all columns", {
skip("ARROW-14045")
compare_dplyr_binding(
Expand Down