Skip to content

Conversation

@anjakefala
Copy link
Contributor

Screenshot from 2022-09-27 17-18-05

@github-actions
Copy link

@kou kou changed the title ARROW-17753: [Python] document cleaning for fixing build environment issues ARROW-17753: [Python][Docs] Document cleaning for fixing build environment issues Sep 28, 2022
Copy link
Member

@AlenkaF AlenkaF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!
LGTM, it is concise and clear.

I approved the changes though comments from Kou still need to be addressed.

I also have to mention that in my case $ git clean -Xfd . in the .../arrow folder does the job for me (no need for three separate deleting steps). But I agree with proposed as there could be different local setups.

@anjakefala
Copy link
Contributor Author

Good to know about the setup.py clean! I removed it. It was the first cleaning step I learned, which was why it was part of my process. =)

I also clarified the conda env files can be manually removed, but did not extensively list all of them.

@anjakefala
Copy link
Contributor Author

As a meta question @jorisvandenbossche is my committing strategy of adding fixup commits the better approach than rebasing as I go?

@jorisvandenbossche
Copy link
Member

As a meta question @jorisvandenbossche is my committing strategy of adding fixup commits the better approach than rebasing as I go?

It's perfect! ;)

@jorisvandenbossche jorisvandenbossche merged commit 7b44e61 into apache:master Sep 30, 2022
@ursabot
Copy link

ursabot commented Sep 30, 2022

Benchmark runs are scheduled for baseline = b3b3046 and contender = 7b44e61. 7b44e61 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.44% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.55% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.04% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 7b44e614 ec2-t3-xlarge-us-east-2
[Finished] 7b44e614 test-mac-arm
[Failed] 7b44e614 ursa-i9-9960x
[Finished] 7b44e614 ursa-thinkcentre-m75q
[Finished] b3b30463 ec2-t3-xlarge-us-east-2
[Finished] b3b30463 test-mac-arm
[Failed] b3b30463 ursa-i9-9960x
[Finished] b3b30463 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants