Skip to content

Conversation

@AlenkaF
Copy link
Member

@AlenkaF AlenkaF commented Oct 7, 2022

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 7, 2022

@jorisvandenbossche
Copy link
Member

You still need to add warnings in the code as well? (warnings.warn(..))

@AlenkaF AlenkaF marked this pull request as draft October 7, 2022 11:29
@AlenkaF
Copy link
Member Author

AlenkaF commented Oct 7, 2022

Thanks @jorisvandenbossche, wasn't sure what is still missing! Will do.

@AlenkaF
Copy link
Member Author

AlenkaF commented Oct 10, 2022

You still need to add warnings in the code as well? (warnings.warn(..))

I have added a warning to the PlasmaClient and ObjectID class but not to PlasmaBuffer as it is not meant to be called directly. Happy to change if my assumption is wrong.

@jorisvandenbossche
Copy link
Member

I have added a warning to the PlasmaClient and ObjectID class but not to PlasmaBuffer as it is not meant to be called directly. Happy to change if my assumption is wrong.

I am not familiar with plasma myself, but looking at our docs for it (https://arrow.apache.org/docs/dev/python/plasma.html): there is also a connect() function, but I suppose that will call PlasmaClient under the hood.
There is also a plasma_store command line, which works through pyarrow._plasma_store_entry_point. That can maybe also print a warning.

It would also be good to verify in the tests that the warning is being raises, and further suppress the warnings (so we don't see them ourselves when running pytest). See for example how I did this in #8255

@AlenkaF AlenkaF marked this pull request as ready for review October 10, 2022 11:57
@AlenkaF AlenkaF requested a review from pitrou October 11, 2022 12:25
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few last small comments!

AlenkaF and others added 2 commits October 12, 2022 10:39
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
@jorisvandenbossche jorisvandenbossche merged commit a02a336 into apache:master Oct 12, 2022
@jorisvandenbossche
Copy link
Member

Thanks @AlenkaF !

@AlenkaF AlenkaF deleted the ARROW-17863 branch October 12, 2022 11:46
@ursabot
Copy link

ursabot commented Oct 13, 2022

Benchmark runs are scheduled for baseline = 69aad53 and contender = a02a336. a02a336 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.56% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.14% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] a02a3369 ec2-t3-xlarge-us-east-2
[Failed] a02a3369 test-mac-arm
[Failed] a02a3369 ursa-i9-9960x
[Finished] a02a3369 ursa-thinkcentre-m75q
[Finished] 69aad53e ec2-t3-xlarge-us-east-2
[Failed] 69aad53e test-mac-arm
[Failed] 69aad53e ursa-i9-9960x
[Finished] 69aad53e ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Oct 13, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants