-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-17863: [Python] Deprecate Plasma Python bindings #14343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…PlasmaClient, PlasmaBuffer
|
You still need to add warnings in the code as well? ( |
|
Thanks @jorisvandenbossche, wasn't sure what is still missing! Will do. |
I have added a warning to the |
I am not familiar with plasma myself, but looking at our docs for it (https://arrow.apache.org/docs/dev/python/plasma.html): there is also a It would also be good to verify in the tests that the warning is being raises, and further suppress the warnings (so we don't see them ourselves when running pytest). See for example how I did this in #8255 |
jorisvandenbossche
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few last small comments!
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
|
Thanks @AlenkaF ! |
|
Benchmark runs are scheduled for baseline = 69aad53 and contender = a02a336. a02a336 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
['Python', 'R'] benchmarks have high level of regressions. |
No description provided.