Skip to content

ARROW-17292: [C++] Segmentation fault on arrow-compute-hash-join-node-test on macos nightlies #14373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vibhatha wants to merge 6 commits into from
Closed

ARROW-17292: [C++] Segmentation fault on arrow-compute-hash-join-node-test on macos nightlies #14373

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aa65851
fix(temp): adding scale factor
vibhatha Oct 5, 2022
35824c7
fix(scale)
vibhatha Oct 6, 2022
367d643
fix(temp)
vibhatha Oct 11, 2022
9d626a3
fix(test)
vibhatha Oct 11, 2022
e0fef0d
fix(temp): reduce the number of tests
vibhatha Oct 12, 2022
0cc2006
fix(test): num_tests variable test
vibhatha Oct 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions cpp/src/arrow/compute/exec/hash_join_node_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1011,7 +1011,7 @@ TEST(HashJoin, Random) {
bool disable_bloom_filter = (rng.from_range(0, 1) == 1);
auto exec_ctx = std::make_unique<ExecContext>(
default_memory_pool(), parallel ? arrow::internal::GetCpuThreadPool() : nullptr);

exec_ctx->set_use_threads(false);
// Constraints
RandomDataTypeConstraints type_constraints;
type_constraints.Default();
Expand All @@ -1033,9 +1033,10 @@ TEST(HashJoin, Random) {
// for EQ only:
// constexpr int key_cmp_mask = 0x01;
constexpr int min_num_rows = 1;
const int max_num_rows = parallel ? 20000 : 2000;
constexpr int min_batch_size = 10;
constexpr int max_batch_size = 100;
const int scale = 1;
const int max_num_rows = parallel ? 20000 * scale : 2000 * scale;
constexpr int min_batch_size = 100 * scale;
constexpr int max_batch_size = 1000 * scale;

// Generate list of key field data types
int num_key_fields = rng.from_range(1, max_num_key_fields);
Expand Down