Skip to content

ARROW-18126: [Python] Remove ARROW_BUILD_DIR in building pyarrow C++ #14498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 1 commit into from
Oct 25, 2022
Merged

ARROW-18126: [Python] Remove ARROW_BUILD_DIR in building pyarrow C++ #14498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions docs/source/developers/python.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,13 +404,6 @@ variable to 1.
To set the number of threads used to compile PyArrow's C++/Cython components,
set the ``PYARROW_PARALLEL`` environment variable.

.. note::

If you used a different directory name for building Arrow C++ (by default it is
named "build"), then you should also set the environment variable
``ARROW_BUILD_DIR='name_of_build_dir'``. This way
PyArrow can find the Arrow C++ built files.

If you wish to delete stale PyArrow build artifacts before rebuilding, navigate
to the ``arrow/python`` folder and run ``git clean -Xfd .``.

Expand Down
4 changes: 0 additions & 4 deletions python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,17 +245,13 @@ def _run_cmake_pyarrow_cpp(self, pyarrow_cpp_home):
# The directory for the module being built
build_dir = pjoin(os.getcwd(), 'build', 'cpp')

# The directory containing Arrow C++ build
arrow_build_dir = os.environ.get('ARROW_BUILD_DIR', 'build')

if not os.path.isdir(build_dir):
self.mkpath(build_dir)

# Change to the build directory
with changed_dir(build_dir):
# cmake args
cmake_options = [
'-DARROW_BUILD_DIR=' + str(arrow_build_dir),
'-DCMAKE_BUILD_TYPE=' + str(self.build_type.lower()),
'-DCMAKE_INSTALL_LIBDIR=lib',
'-DCMAKE_INSTALL_PREFIX=' + str(pyarrow_cpp_home),
Expand Down