Skip to content

ARROW-18399: [Python] Reduce warnings during tests #14729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jorisvandenbossche merged 20 commits into from
Nov 30, 2022
Merged

ARROW-18399: [Python] Reduce warnings during tests #14729

jorisvandenbossche merged 20 commits into from
Nov 30, 2022

Conversation

@milesgranger
Copy link
Contributor

@milesgranger milesgranger commented Nov 24, 2022 •
edited
Loading

Will fix ARROW-18399

Also closes ARROW-18125

@github-actions
Copy link

github-actions bot commented Nov 24, 2022

https://issues.apache.org/jira/browse/ARROW-18399

@milesgranger milesgranger marked this pull request as draft November 24, 2022 14:35
@milesgranger milesgranger marked this pull request as ready for review November 25, 2022 11:45
@milesgranger
Copy link
Contributor Author

milesgranger commented Nov 25, 2022 •
edited
Loading

This appears to remove all warnings in the CI with pandas and without.

I assume we don't want to turn warnings into errors? Maybe that's too frustrating since unrelated warnings can always pop up in subsequent PRs?

@pitrou
Copy link
Member

pitrou commented Nov 25, 2022

I assume we don't want to turn warnings into errors? Maybe that's too frustrating since unrelated warnings can always pop up in subsequent PRs?

Yes, it would definitely be frustrating.

AlenkaF
AlenkaF approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@AlenkaF AlenkaF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through the changes and the CI, looks good to me 👍

pitrou
pitrou reviewed Nov 28, 2022
View reviewed changes
@pitrou
Copy link
Member

pitrou commented Nov 28, 2022

(sorry, some of those comments were actually written days ago, but I had forgotten to submit the review...)

@milesgranger milesgranger mentioned this pull request Nov 29, 2022
Closed
jorisvandenbossche
jorisvandenbossche reviewed Nov 29, 2022
View reviewed changes
jorisvandenbossche
jorisvandenbossche reviewed Nov 29, 2022
View reviewed changes
jorisvandenbossche
jorisvandenbossche reviewed Nov 29, 2022
View reviewed changes
jorisvandenbossche
jorisvandenbossche reviewed Nov 29, 2022
View reviewed changes
milesgranger
milesgranger commented Nov 29, 2022
View reviewed changes
@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Nov 29, 2022

Can you merge master to get rid of the failure?

@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Nov 29, 2022

Actually, it's only the label workflow (the linter passed), so don't worry

@jorisvandenbossche jorisvandenbossche merged commit a497f28 into apache:master Nov 30, 2022
@milesgranger milesgranger deleted the ARROW-18399_reduce-warnings-during-tests branch November 30, 2022 08:24
@ursabot
Copy link

ursabot commented Nov 30, 2022

Benchmark runs are scheduled for baseline = 2e9611a and contender = a497f28. a497f28 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.03%] test-mac-arm
[Finished ⬇️0.54% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.98% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] a497f28f ec2-t3-xlarge-us-east-2
[Failed] a497f28f test-mac-arm
[Finished] a497f28f ursa-i9-9960x
[Finished] a497f28f ursa-thinkcentre-m75q
[Finished] 2e9611a8 ec2-t3-xlarge-us-east-2
[Failed] 2e9611a8 test-mac-arm
[Finished] 2e9611a8 ursa-i9-9960x
[Finished] 2e9611a8 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Nov 30, 2022

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

@asfimport asfimport mentioned this pull request Nov 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pitrou pitrou pitrou left review comments

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

@AlenkaF AlenkaF AlenkaF approved these changes

Assignees

No one assigned

Labels

Component: Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@milesgranger @pitrou @jorisvandenbossche @ursabot @AlenkaF