ARROW-18413: [C++][Parquet] Expose page index info from ColumnChunkMetaData #14742
Conversation
|
|
|
@pitrou @emkornfield Can you please take a look? As I have mentioned in other thread, I will work on the page index and break it down into small commits to make it review-friendly. |
wgtmac
changed the title
cpp/src/parquet/metadata.h
Outdated
| std::unique_ptr<ColumnCryptoMetaData> crypto_metadata() const; | ||
|
|
||
| bool has_column_index() const; | ||
| int64_t column_index_offset() const; |
There was a problem hiding this comment.
I think it might be a clearer contract to have something like:
struct IndexLocation {
int64_t index_file_offset_bytes;
int32_t offset_index_length
}
optional<IndexLocation> GetColumIndexLocation();
optional<IndexLocation> GetOffsetIndexLocation();
Thoughts?
There was a problem hiding this comment.
SGTM, I will change it shortly.
|
I have addressed your comment, and the unsuccessful CI checks are unrelated to my change. Can you please take a look again? @emkornfield |
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
Thank you. Is it possible to add basic tests for this?
Thank you for the review. @pitrou I have added a simple test and addressed your comment. Please take a look again when you get the chance. |
|
Test failures are unrelated, will merge. |
|
Benchmark runs are scheduled for baseline = 6f4a539 and contender = 958fbfa. 958fbfa is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
4 participants
This is the first step to support page index of parquet.