Skip to content

GH-14866: [C++] Remove internal GroupBy implementation #14867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
westonpace merged 4 commits into from
Feb 21, 2023
Merged

GH-14866: [C++] Remove internal GroupBy implementation #14867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
777d136
GH-14866: Modified arrow::internal::GroupBy to use an exec plan direc…
westonpace Dec 7, 2022
cd40e50
Added some comments for clarification. Removed debug print
westonpace Jan 25, 2023
83f9c46
Lint
westonpace Feb 17, 2023
414eabe
Fix BatchGroupBy to actually accept a batch. Fix benchmark
westonpace Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/src/arrow/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ if(ARROW_COMPUTE)
compute/api_vector.cc
compute/cast.cc
compute/exec.cc
compute/exec/aggregate.cc
compute/exec/groupby.cc
compute/exec/accumulation_queue.cc
compute/exec/aggregate_node.cc
compute/exec/asof_join_node.cc
Expand Down
1 change: 1 addition & 0 deletions cpp/src/arrow/compute/api.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,3 +58,4 @@

#include "arrow/compute/exec.h" // IWYU pragma: export
#include "arrow/compute/exec/exec_plan.h" // IWYU pragma: export
#include "arrow/compute/exec/groupby.h" // IWYU pragma: export
1 change: 1 addition & 0 deletions cpp/src/arrow/compute/exec/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ add_arrow_compute_test(asof_join_node_test
test_nodes.cc)
add_arrow_compute_test(tpch_node_test PREFIX "arrow-compute")
add_arrow_compute_test(union_node_test PREFIX "arrow-compute")
add_arrow_compute_test(groupby_test PREFIX "arrow-compute")
add_arrow_compute_test(util_test
PREFIX
"arrow-compute"
Expand Down
300 changes: 0 additions & 300 deletions cpp/src/arrow/compute/exec/aggregate.cc
View file
Open in desktop

This file was deleted.

60 changes: 0 additions & 60 deletions cpp/src/arrow/compute/exec/aggregate.h
View file
Open in desktop

This file was deleted.

Loading