Skip to content

GH-15136: [Python][macOS] Use @rpath for libarrow_python.dylib #15143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kou merged 2 commits into from
Jan 3, 2023
Merged

GH-15136: [Python][macOS] Use @rpath for libarrow_python.dylib #15143

kou merged 2 commits into from
Jan 3, 2023

Conversation

@kou
Copy link
Member

@kou kou commented Dec 31, 2022 •
edited by github-actions bot
Loading

@github-actions
Copy link

github-actions bot commented Dec 31, 2022

@kou
Copy link
Member Author

kou commented Dec 31, 2022

@github-actions crossbow submit -g python

@github-actions

This comment was marked as outdated.

Sign in to view
@kou
Copy link
Member Author

kou commented Jan 1, 2023

@github-actions crossbow submit -g python

@github-actions
Copy link

github-actions bot commented Jan 1, 2023

Revision: 340a9e9

Submitted crossbow builds: ursacomputing/crossbow @ actions-2d14361de8

Task Status
test-conda-python-3.10 Github Actions
test-conda-python-3.11 Github Actions
test-conda-python-3.7 Github Actions
test-conda-python-3.7-hdfs-2.9.2 Github Actions
test-conda-python-3.7-hdfs-3.2.1 Github Actions
test-conda-python-3.7-pandas-1.0 Github Actions
test-conda-python-3.7-pandas-latest Github Actions
test-conda-python-3.7-spark-v3.1.2 Github Actions
test-conda-python-3.8 Github Actions
test-conda-python-3.8-hypothesis Github Actions
test-conda-python-3.8-pandas-latest Github Actions
test-conda-python-3.8-pandas-nightly Github Actions
test-conda-python-3.8-spark-v3.2.0 Github Actions
test-conda-python-3.9 Github Actions
test-conda-python-3.9-dask-latest Github Actions
test-conda-python-3.9-dask-upstream_devel Github Actions
test-conda-python-3.9-pandas-upstream_devel Github Actions
test-conda-python-3.9-spark-master Github Actions
test-cuda-python Github Actions
test-debian-11-python-3 Azure
test-fedora-35-python-3 Azure
test-ubuntu-20.04-python-3 Azure

@kou
Copy link
Member Author

kou commented Jan 1, 2023

@github-actions crossbow submit -g wheel

@kou
Copy link
Member Author

kou commented Jan 1, 2023

@github-actions crossbow submit -g conda

@github-actions
Copy link

github-actions bot commented Jan 1, 2023

Revision: 340a9e9

Submitted crossbow builds: ursacomputing/crossbow @ actions-bc711f6501

Task Status
conda-clean Azure
conda-linux-aarch64-cpu-py3 Azure
conda-linux-aarch64-cpu-r41 Azure
conda-linux-aarch64-cpu-r42 Azure
conda-linux-ppc64le-cpu-py3 Azure
conda-linux-x64-cpu-py3 Azure
conda-linux-x64-cpu-r41 Azure
conda-linux-x64-cpu-r42 Azure
conda-linux-x64-cuda-py3 Azure
conda-osx-arm64-cpu-py3 Azure
conda-osx-arm64-cpu-r41 Azure
conda-osx-arm64-cpu-r42 Azure
conda-osx-x64-cpu-py3 Azure
conda-osx-x64-cpu-r41 Azure
conda-osx-x64-cpu-r42 Azure
conda-win-x64-cpu-py3 Azure
conda-win-x64-cpu-r41 Azure
conda-win-x64-cuda-py3 Azure

@github-actions
Copy link

github-actions bot commented Jan 1, 2023

Revision: 340a9e9

Submitted crossbow builds: ursacomputing/crossbow @ actions-8859219c39

Task Status
wheel-macos-big-sur-cp310-arm64 Github Actions
wheel-macos-big-sur-cp311-arm64 Github Actions
wheel-macos-big-sur-cp38-arm64 Github Actions
wheel-macos-big-sur-cp39-arm64 Github Actions
wheel-macos-mojave-cp310-amd64 Github Actions
wheel-macos-mojave-cp311-amd64 Github Actions
wheel-macos-mojave-cp37-amd64 Github Actions
wheel-macos-mojave-cp38-amd64 Github Actions
wheel-macos-mojave-cp39-amd64 Github Actions
wheel-manylinux2014-cp310-amd64 Github Actions
wheel-manylinux2014-cp310-arm64 Travis CI
wheel-manylinux2014-cp311-amd64 Github Actions
wheel-manylinux2014-cp311-arm64 Travis CI
wheel-manylinux2014-cp37-amd64 Github Actions
wheel-manylinux2014-cp37-arm64 Travis CI
wheel-manylinux2014-cp38-amd64 Github Actions
wheel-manylinux2014-cp38-arm64 Travis CI
wheel-manylinux2014-cp39-amd64 Github Actions
wheel-manylinux2014-cp39-arm64 Travis CI
wheel-windows-cp310-amd64 Github Actions
wheel-windows-cp311-amd64 Github Actions
wheel-windows-cp37-amd64 Github Actions
wheel-windows-cp38-amd64 Github Actions
wheel-windows-cp39-amd64 Github Actions

@kou
Copy link
Member Author

kou commented Jan 1, 2023

@wjones127 Could you confirm that this solves #15136 in your environment?

@wjones127
Copy link
Member

wjones127 commented Jan 2, 2023

Building off this branch, I can import pyarrow 👍

Looks like it is using @rpath:

> otool pyarrow/lib.cpython-310-darwin.so -L
pyarrow/lib.cpython-310-darwin.so:
        @rpath/libarrow_python.dylib (compatibility version 0.0.0, current version 0.0.0)
        /Users/willjones/mambaforge/envs/arrow-dev/lib/libarrow.1100.dylib (compatibility version 1100.0.0, current version 1100.0.0)
        @rpath/libc++.1.dylib (compatibility version 1.0.0, current version 1.0.0)
        /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1311.100.3)

@kou
Copy link
Member Author

kou commented Jan 3, 2023

Thanks for confirming this.
I merge this.

@kou kou merged commit 240ebb7 into apache:master Jan 3, 2023
@kou kou deleted the python-not-use-add-arrow-lib branch January 3, 2023 12:27
@ursabot
Copy link

ursabot commented Jan 3, 2023

Benchmark runs are scheduled for baseline = 4a40a82 and contender = 240ebb7. 240ebb7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.0% ⬆️0.0%] test-mac-arm
[Finished ⬇️2.3% ⬆️0.51%] ursa-i9-9960x
[Failed ⬇️2.86% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 240ebb75 ec2-t3-xlarge-us-east-2
[Failed] 240ebb75 test-mac-arm
[Finished] 240ebb75 ursa-i9-9960x
[Failed] 240ebb75 ursa-thinkcentre-m75q
[Finished] 4a40a829 ec2-t3-xlarge-us-east-2
[Failed] 4a40a829 test-mac-arm
[Finished] 4a40a829 ursa-i9-9960x
[Failed] 4a40a829 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Jan 3, 2023

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

EpsilonPrime pushed a commit to EpsilonPrime/arrow that referenced this pull request Jan 5, 2023
@kou @EpsilonPrime
apacheGH-15136: [Python][macOS] Use @rpath for libarrow_python.dylib (
302e80a 
apache#15143)

* Closes: apache#15136

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@assignUser assignUser mentioned this pull request Jan 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wjones127 wjones127 wjones127 approved these changes

Assignees

No one assigned

Labels

Component: C++ Component: Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Python] Python C++ libraries no longer in pyarrow/lib directory

3 participants

@kou @wjones127 @ursabot