-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-2153/ARROW-2160: [C++/Python] Fix decimal precision inference #1618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cpp/src/arrow/python/helpers.cc
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This requires ARROW-2145 to address.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to wait for ARROW-2145 or merge this independently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a couple more tests to add here
8067876 to
0d7f252
Compare
|
@wesm @pitrou I reintroduced boost regex for parsing the decimal number, to address ARROW-2153. We were using a fairly straightforward algorithm before that implemented the regular expression by hand but it didn't allow numbers like |
|
|
|
Yep, I believe |
|
In gcc 4.8 that is. 4.9 may be implemented, but I don't think it supports named capture groups. |
|
needs rebase |
|
Closed in favor of #1651 |
No description provided.