-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-2436: [Rust] Add windows CI #1949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
6233c96
Updated windows ci to include Rust
paddyhoran 24e839c
Updated install section.
paddyhoran 17adfad
Move into rust folder before testing
paddyhoran f00d517
Disable CLCACHE for Rust builds
paddyhoran 9ec5d57
Added license
paddyhoran 68c183b
Temporarily disabling other build jobs.
paddyhoran e94ff0e
Testing multi-line if block
paddyhoran 0b5099f
Removed `BUILD_SCRIPT` variable
paddyhoran e976fa9
Cleaned up appveyor.yml
paddyhoran c6723d3
Cleaned up build and install scripts.
paddyhoran 9e8574c
Moving Rust build to end.
paddyhoran 3c94bdf
Updating scripts to assume root directory.
paddyhoran 7a3ef5a
Testing branches of if statement.
paddyhoran 25d3747
Testing variable change.
paddyhoran c26100f
Restoring quotes.
paddyhoran 2405086
Try adding quotes when setting PATH
pitrou 7f8b050
Wrapping MINICONDA in double quotes
paddyhoran 82f68d8
Trying to confirm source of error
paddyhoran bad1f18
Restoring order of %PATH%
paddyhoran File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| @rem Licensed to the Apache Software Foundation (ASF) under one | ||
| @rem or more contributor license agreements. See the NOTICE file | ||
| @rem distributed with this work for additional information | ||
| @rem regarding copyright ownership. The ASF licenses this file | ||
| @rem to you under the Apache License, Version 2.0 (the | ||
| @rem "License"); you may not use this file except in compliance | ||
| @rem with the License. You may obtain a copy of the License at | ||
| @rem | ||
| @rem http://www.apache.org/licenses/LICENSE-2.0 | ||
| @rem | ||
| @rem Unless required by applicable law or agreed to in writing, | ||
| @rem software distributed under the License is distributed on an | ||
| @rem "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| @rem KIND, either express or implied. See the License for the | ||
| @rem specific language governing permissions and limitations | ||
| @rem under the License. | ||
|
|
||
| @echo on | ||
|
|
||
| if "%JOB%" == "Rust_Stable" ( | ||
| cd rust | ||
| cargo build --target %TARGET% || exit /B | ||
| cargo build --target %TARGET% --release || exit /B | ||
| cargo test --target %TARGET% || exit /B | ||
| cargo test --target %TARGET% --release || exit /B | ||
| ) else ( | ||
| git config core.symlinks true | ||
| git reset --hard | ||
| if "%JOB%"=="Cmake_Script_Tests" ( | ||
| call ci\test-cmake-build-script.bat | ||
| ) else ( | ||
| call ci\cpp-python-msvc-build.bat | ||
| ) | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| @rem Licensed to the Apache Software Foundation (ASF) under one | ||
| @rem or more contributor license agreements. See the NOTICE file | ||
| @rem distributed with this work for additional information | ||
| @rem regarding copyright ownership. The ASF licenses this file | ||
| @rem to you under the Apache License, Version 2.0 (the | ||
| @rem "License"); you may not use this file except in compliance | ||
| @rem with the License. You may obtain a copy of the License at | ||
| @rem | ||
| @rem http://www.apache.org/licenses/LICENSE-2.0 | ||
| @rem | ||
| @rem Unless required by applicable law or agreed to in writing, | ||
| @rem software distributed under the License is distributed on an | ||
| @rem "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| @rem KIND, either express or implied. See the License for the | ||
| @rem specific language governing permissions and limitations | ||
| @rem under the License. | ||
|
|
||
| @echo on | ||
|
|
||
| if "%JOB%" == "Rust_Stable" ( | ||
| curl -sSf -o rustup-init.exe https://win.rustup.rs/ | ||
| rustup-init.exe -y --default-host %TARGET% --default-toolchain %RUST_VERSION% | ||
| set "PATH=%PATH%;C:\Users\Appveyor\.cargo\bin" | ||
| rustc -Vv | ||
| cargo -V | ||
| ) else ( | ||
| set "PATH=C:\Miniconda36-x64;C:\Miniconda36-x64\Scripts;C:\Miniconda36-x64\Library\bin;%PATH%" | ||
| call ci\appveyor-setup.bat | ||
| ) |
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point we will want to selectively disable some matrix builds based on the modified files, as we already do for Travis-CI. The
ci/travis_detect_changes.pyscript does that, it can be extended for AppVeyor. The following logic (from CPython) is supposed to be able to detect changed files on AppVeyor PRs:https://github.com/python/cpython/blob/master/.github/appveyor.yml#L12-L26
Builds already pile up quickly due to concurrency limitations on AppVeyor, ideally we should not make things worse.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, it's pretty annoying that all cpp builds would re-trigger on changes to the PR. I'll create a JIRA for it. It's probably something I could take a look at.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JIRA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!