ARROW-2578: [Plasma] Use mersenne twister to generate random number #2039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcmoritz
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2039 +/- ##
==========================================
+ Coverage 86.28% 87.48% +1.19%
==========================================
Files 11 178 +167
Lines 773 28595 +27822
==========================================
+ Hits 667 25015 +24348
- Misses 106 3580 +3474
Continue to review full report at Codecov.
|
cpp/src/plasma/common.cc
Outdated
| #include <limits> | ||
| #include <mutex> | ||
| #include <random> | ||
| #include <thread> |
Contributor
There was a problem hiding this comment.
Is this still needed?
cpp/src/plasma/common.cc
Outdated
| static std::mutex mutex; | ||
| std::lock_guard<std::mutex> lock(mutex); | ||
| static std::mt19937 generator; | ||
| std::uniform_int_distribution<uint32_t> d(0, std::numeric_limits<uint8_t>::max()); |
Contributor
There was a problem hiding this comment.
minor, but I'm not a huge fan of the variable name d
Contributor
Author
|
+1 merging this now to remove the valgrind testing error |
Member
|
This PR is constructing a generator with a fixed seed, so now distinct processes will trivially collide when generate random ids: |
Contributor
Author
|
I just saw this and opened a JIRA here: https://issues.apache.org/jira/browse/ARROW-3018 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of the std::random_device, which is slow and causes errors in valgrind. Instead we use the std::mt19937 Mersenne Twister.