-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-2604: [Java] Add convenience method to VarCharVector to set Text #2071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-2604: [Java] Add convenience method to VarCharVector to set Text #2071
Conversation
|
I had also wondered why there was no method to set a String directly in btw, it seems hadoop users are familiar with using |
icexelloss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
|
I am curious about the choice of using |
|
I'll commit this later today if no more comments. We can discuss further if there is still interest in adding an api directly for setting |
siddharthteotia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
|
Thanks @icexelloss and @siddharthteotia ! merged to master |
This adds a convenience method to easily set values in `VarCharVector` using the friendly type `Text`. This allows the user to set values without having to think about the correct encoding. Text objects can be constructed from a String using the constructor `Text(String string)`. Extended existing test to set/get a `VarCharVector` using `Text` objects. Author: Bryan Cutler <cutlerb@gmail.com> Closes apache#2071 from BryanCutler/java-varchar-from-string-ARROW-2604 and squashes the following commits: 5579edb <Bryan Cutler> add set Text to VarCharVector
This adds a convenience method to easily set values in
VarCharVectorusing the friendly typeText. This allows the user to set values without having to think about the correct encoding. Text objects can be constructed from a String using the constructorText(String string).Extended existing test to set/get a
VarCharVectorusingTextobjects.