Skip to content

GH-33777: [R] Nightly builds failing due to dataset test not being skipped on builds without datasets module #33778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thisisnic merged 1 commit into from
Jan 19, 2023
Merged

GH-33777: [R] Nightly builds failing due to dataset test not being skipped on builds without datasets module #33778

thisisnic merged 1 commit into from
Jan 19, 2023

Conversation

@thisisnic
Copy link
Member

@thisisnic thisisnic commented Jan 19, 2023 •
edited
Loading

The minimal builds were failing due to a new test which requires the datasets module; I've just skipped this test on builds where this module isn't installed.

@github-actions
Copy link

github-actions bot commented Jan 19, 2023

@thisisnic
Copy link
Member Author

thisisnic commented Jan 19, 2023

@github-actions crossbow submit test-r-minimal-build

@github-actions
Copy link

github-actions bot commented Jan 19, 2023

Revision: de1d764

Submitted crossbow builds: ursacomputing/crossbow @ actions-8bd0b2f0ff

Task Status
test-r-minimal-build Azure

@paleolimbot
Copy link
Member

paleolimbot commented Jan 19, 2023

@github-actions crossbow submit test-r-offline-minimal

@github-actions
Copy link

github-actions bot commented Jan 19, 2023

Revision: de1d764

Submitted crossbow builds: ursacomputing/crossbow @ actions-ae4cf10f4d

Task Status
test-r-offline-minimal Azure

paleolimbot
paleolimbot approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@thisisnic thisisnic merged commit a1a587b into apache:master Jan 19, 2023
@paleolimbot paleolimbot mentioned this pull request Jan 19, 2023
Merged
@ursabot
Copy link

ursabot commented Jan 20, 2023

Benchmark runs are scheduled for baseline = fc1f9eb and contender = a1a587b. a1a587b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.87% ⬆️0.0%] test-mac-arm
[Failed] ursa-i9-9960x
[Failed] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] a1a587b1 ec2-t3-xlarge-us-east-2
[Finished] a1a587b1 test-mac-arm
[Failed] a1a587b1 ursa-i9-9960x
[Failed] a1a587b1 ursa-thinkcentre-m75q
[Finished] fc1f9ebb ec2-t3-xlarge-us-east-2
[Finished] fc1f9ebb test-mac-arm
[Failed] fc1f9ebb ursa-i9-9960x
[Failed] fc1f9ebb ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Jan 20, 2023

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paleolimbot paleolimbot paleolimbot approved these changes

Assignees

No one assigned

Labels

Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[R] Nightly builds failing due to dataset test not being skipped on builds without datasets module

3 participants

@thisisnic @paleolimbot @ursabot