-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-33801: [Python] Expose C++ ExtensionTypes/ExtensionArrays in pyarrow #33802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-33801: [Python] Expose C++ ExtensionTypes/ExtensionArrays in pyarrow #33802
Conversation
|
|
jorisvandenbossche
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this PR! (and sorry for the slow feedback)
Looking good, added some comments.
|
@sjperkins FYI I also opened an issue about having custom subclasses for extension types implemented in C++ (instead of using the base class BaseExtensionType/ExtensionArray): #33997 |
Thanks @jorisvandenbossche for mentioning this, as well as the review. I'm intending to address your review comments next week. |
|
Is there anything else needed from me on this PR? |
jorisvandenbossche
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, nothing else needed, this looks good! (and thanks for the ping :))
|
Thanks for the review and merging @jorisvandenbossche |
|
Benchmark runs are scheduled for baseline = b40fb2c and contender = 1333545. 1333545 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
['Python', 'R'] benchmarks have high level of regressions. |
Rationale for this change
C++ Extension Types are not correctly exposed in pyarrow
What changes are included in this PR?
__arrow_ext_class__and__arrow_ext_scalar_class__have been moved fromExtensionTypetoBaseExtensionTypein types.pxi.Are these changes tested?
Yes, a test has been added to
test_cython.py. There may be better locations for this, but the existing cython testing machinery here is useful for generating a C++ extension type on the fly.Are there any user-facing changes?
I don't believe there are any user-facing changes as
__arrow_ext_class__and__arrow_ext_scalar_class__are moved into a base class.