Skip to content

GH-32619: [Python][Docs] Include options for PyArrow build explicitly #34463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jorisvandenbossche merged 11 commits into from
Mar 10, 2023
Merged

GH-32619: [Python][Docs] Include options for PyArrow build explicitly #34463

jorisvandenbossche merged 11 commits into from
Mar 10, 2023

Conversation

@AlenkaF
Copy link
Member

@AlenkaF AlenkaF commented Mar 6, 2023 •
edited
Loading

What changes are included in this PR?

List of relevant build options for PyArrow added to the python dev docs.

This PR also removes these flags from PyArrow:

  • PYARROW_BUNDLE_BOOST
  • PYARROW_BUNDLE_ARROW_CPP_HEADERS
  • PYARROW_WITH_STATIC_PARQUET
  • PYARROW_PARQUET_USE_SHARED

@github-actions
Copy link

github-actions bot commented Mar 6, 2023

AlenkaF
AlenkaF commented Mar 6, 2023
View reviewed changes
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Mar 6, 2023
AlenkaF
AlenkaF commented Mar 6, 2023
View reviewed changes
kou
kou reviewed Mar 6, 2023
View reviewed changes
@AlenkaF @kou
Apply suggestions from code review - kou
d33bc73 
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
@github-actions github-actions bot added awaiting change review Awaiting change review awaiting changes Awaiting changes and removed awaiting changes Awaiting changes awaiting change review Awaiting change review labels Mar 7, 2023
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Mar 7, 2023
@AlenkaF
Copy link
Member Author

AlenkaF commented Mar 8, 2023

@github-actions crossbow submit wheel-windows*

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Revision: a4dd385

Submitted crossbow builds: ursacomputing/crossbow @ actions-481c2526f6

Task Status
wheel-windows-cp310-amd64 Github Actions
wheel-windows-cp311-amd64 Github Actions
wheel-windows-cp37-amd64 Github Actions
wheel-windows-cp38-amd64 Github Actions
wheel-windows-cp39-amd64 Github Actions

@AlenkaF AlenkaF requested a review from kou March 8, 2023 10:41
@AlenkaF
Copy link
Member Author

AlenkaF commented Mar 8, 2023

@ksuarez1423 pinging you as you might be interested in reviewing the changes in this PR.

@AlenkaF
Copy link
Member Author

AlenkaF commented Mar 8, 2023

@github-actions crossbow submit preview-docs

@github-actions
Copy link

github-actions bot commented Mar 8, 2023

Revision: a4dd385

Submitted crossbow builds: ursacomputing/crossbow @ actions-7c1c5b5e77

Task Status
preview-docs Github Actions

kou
kou approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Mar 8, 2023
jorisvandenbossche
jorisvandenbossche reviewed Mar 9, 2023
View reviewed changes
jorisvandenbossche
jorisvandenbossche reviewed Mar 9, 2023
View reviewed changes
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels Mar 9, 2023
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Mar 9, 2023
assignUser
assignUser approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@jorisvandenbossche jorisvandenbossche merged commit 4c05a3b into apache:main Mar 10, 2023
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels Mar 10, 2023
@AlenkaF AlenkaF deleted the gh-32619-build-options-pyarrow-docs branch March 10, 2023 09:34
@ursabot
Copy link

ursabot commented Mar 10, 2023

Benchmark runs are scheduled for baseline = ad44e8e and contender = 4c05a3b. 4c05a3b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.97% ⬆️0.03%] test-mac-arm
[Finished ⬇️1.53% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.85% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 4c05a3b4 ec2-t3-xlarge-us-east-2
[Finished] 4c05a3b4 test-mac-arm
[Finished] 4c05a3b4 ursa-i9-9960x
[Finished] 4c05a3b4 ursa-thinkcentre-m75q
[Finished] ad44e8e4 ec2-t3-xlarge-us-east-2
[Failed] ad44e8e4 test-mac-arm
[Finished] ad44e8e4 ursa-i9-9960x
[Finished] ad44e8e4 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou kou approved these changes

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

@assignUser assignUser assignUser approved these changes

@raulcd raulcd Awaiting requested review from raulcd raulcd is a code owner

Assignees

No one assigned

Labels

awaiting merge Awaiting merge Component: Documentation Component: Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Python][Docs] Include options for PyArrow build explicitly

5 participants

@AlenkaF @ursabot @kou @jorisvandenbossche @assignUser