Skip to content

GH-34670: [Packaging][C++] Add support for customizing GDB plugin install directory #34672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kou merged 2 commits into from
Mar 24, 2023
Merged

GH-34670: [Packaging][C++] Add support for customizing GDB plugin install directory #34672

kou merged 2 commits into from
Mar 24, 2023

Conversation

@kou
Copy link
Member

@kou kou commented Mar 22, 2023 •
edited by github-actions bot
Loading

Rationale for this change

It's for conda package. We can't determine the final GDB plugin path on building. We can adjust the path by replacing a placeholder on installing.

What changes are included in this PR?

Conda package can specify a placeholder for GDB plugin path.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

@kou
Copy link
Member Author

kou commented Mar 22, 2023

@github-actions crossbow submit -g linux

@github-actions
Copy link

github-actions bot commented Mar 22, 2023

@github-actions
Copy link

github-actions bot commented Mar 22, 2023

⚠️ GitHub issue #34670 has been automatically assigned in GitHub to PR creator.

@kou kou mentioned this pull request Mar 22, 2023
Closed
@github-actions

This comment was marked as outdated.

Sign in to view
@kou
Copy link
Member Author

kou commented Mar 24, 2023

@github-actions crossbow submit -g linux

@github-actions
Copy link

github-actions bot commented Mar 24, 2023

Revision: dc90ff1

Submitted crossbow builds: ursacomputing/crossbow @ actions-baef4906c1

Task Status
almalinux-8-amd64 Github Actions
almalinux-8-arm64 Travis CI
almalinux-9-amd64 Github Actions
almalinux-9-arm64 Travis CI
amazon-linux-2-amd64 Github Actions
amazon-linux-2-arm64 Travis CI
centos-7-amd64 Github Actions
centos-8-stream-amd64 Github Actions
centos-8-stream-arm64 Travis CI
centos-9-stream-amd64 Github Actions
centos-9-stream-arm64 Travis CI
debian-bookworm-amd64 Github Actions
debian-bookworm-arm64 Travis CI
debian-bullseye-amd64 Github Actions
debian-bullseye-arm64 Travis CI
ubuntu-bionic-amd64 Github Actions
ubuntu-bionic-arm64 Travis CI
ubuntu-focal-amd64 Github Actions
ubuntu-focal-arm64 Travis CI
ubuntu-jammy-amd64 Github Actions
ubuntu-jammy-arm64 Travis CI
ubuntu-kinetic-amd64 Github Actions
ubuntu-kinetic-arm64 Travis CI

@kou
Copy link
Member Author

kou commented Mar 24, 2023

+1

@kou kou merged commit a18382c into apache:main Mar 24, 2023
@kou kou deleted the cpp-gdb-installd-dir branch March 24, 2023 22:18
@ursabot
Copy link

ursabot commented Mar 25, 2023

Benchmark runs are scheduled for baseline = 1b439b0 and contender = a18382c. a18382c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.42% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.26% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.18% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] a18382c1 ec2-t3-xlarge-us-east-2
[Finished] a18382c1 test-mac-arm
[Finished] a18382c1 ursa-i9-9960x
[Finished] a18382c1 ursa-thinkcentre-m75q
[Finished] 1b439b07 ec2-t3-xlarge-us-east-2
[Finished] 1b439b07 test-mac-arm
[Finished] 1b439b07 ursa-i9-9960x
[Finished] 1b439b07 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@kou
Copy link
Member Author

kou commented Apr 11, 2023

@github-actions crossbow submit test-conda-python-3.10

@github-actions
Copy link

github-actions bot commented Apr 11, 2023

Revision: dc90ff1

Submitted crossbow builds: ursacomputing/crossbow @ actions-a9ac140441

Task Status
test-conda-python-3.10 Github Actions

ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@kou @ArgusLi
apacheGH-34670: [Packaging][C++] Add support for customizing GDB plug…
8b36e86 
…in install directory (apache#34672)

### Rationale for this change

It's for conda package. We can't determine the final GDB plugin path on building. We can adjust the path by replacing a placeholder on installing. 

### What changes are included in this PR?

Conda package can specify a placeholder for GDB plugin path.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#34670

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting committer review Awaiting committer review Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Packaging][C++] gdb integration is not compatible with conda packaging

2 participants

@kou @ursabot