Skip to content

ARROW-459: [C++] Dictionary IPC support in file and stream formats #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wesm wants to merge 12 commits into from
Closed

ARROW-459: [C++] Dictionary IPC support in file and stream formats #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d537004
Add support for deconstructing and reconstructing DictionaryArray wit…
wesm Feb 21, 2017
6858e12
Add union and dictionary to file/stream tests
wesm Feb 21, 2017
ae389fa
WIP progress toward stream/file dictionary roundtrip
wesm Feb 21, 2017
1cee0ff
More progress toward file/stream roundtrips with dictionaries
wesm Feb 22, 2017
cb04a41
Refactoring. Remove FileFooter class in favor of private impl in File…
wesm Feb 22, 2017
ef9dea8
More dictionary support in FileReader. Simple test passes
wesm Feb 22, 2017
acfa994
cpplint
wesm Feb 22, 2017
e5cec27
Add some less trivial dictionary-encoded arrays to test case
wesm Feb 23, 2017
7ac756e
Fix Python build
wesm Feb 23, 2017
dee044e
Review comments
wesm Feb 23, 2017
8e0e6fb
Fix bug causing valgrind failure
wesm Feb 23, 2017
6a987b7
Fix clang warning with forward declaration
wesm Feb 23, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,9 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL "${CMAKE_CURRENT_SOURCE_DIR}")
ON)
endif()

if(NOT ARROW_BUILD_TESTS)
if(ARROW_BUILD_TESTS)
set(ARROW_BUILD_STATIC ON)
else()
set(NO_TESTS 1)
endif()

Expand Down
2 changes: 2 additions & 0 deletions cpp/src/arrow/array.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ class Status;

class ArrayVisitor {
public:
virtual ~ArrayVisitor() = default;

virtual Status Visit(const NullArray& array) = 0;
virtual Status Visit(const BooleanArray& array) = 0;
virtual Status Visit(const Int8Array& array) = 0;
Expand Down
9 changes: 2 additions & 7 deletions cpp/src/arrow/io/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,8 @@ set(ARROW_IO_STATIC_PRIVATE_LINK_LIBS
boost_system_static
boost_filesystem_static)

if (ARROW_BUILD_STATIC)
set(ARROW_IO_TEST_LINK_LIBS
arrow_io_static)
else()
set(ARROW_IO_TEST_LINK_LIBS
arrow_io_shared)
endif()
set(ARROW_IO_TEST_LINK_LIBS
arrow_io_static)

set(ARROW_IO_SRCS
file.cc
Expand Down
15 changes: 2 additions & 13 deletions cpp/src/arrow/ipc/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,20 +24,9 @@ set(ARROW_IPC_SHARED_LINK_LIBS
arrow_shared
)

set(ARROW_IPC_STATIC_LINK_LIBS
arrow_static
set(ARROW_IPC_TEST_LINK_LIBS
arrow_io_static
)

if (ARROW_BUILD_STATIC)
set(ARROW_IPC_TEST_LINK_LIBS
arrow_io_static
arrow_ipc_static)
else()
set(ARROW_IPC_TEST_LINK_LIBS
arrow_io_shared
arrow_ipc_shared)
endif()
arrow_ipc_static)

set(ARROW_IPC_SRCS
adapter.cc
Expand Down
Loading