Skip to content

GH-34869: [C++] Configure alpine linux nightly job to build gtest from source #34870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kou merged 2 commits into from
Apr 5, 2023
Merged

GH-34869: [C++] Configure alpine linux nightly job to build gtest from source #34870

kou merged 2 commits into from
Apr 5, 2023

Conversation

@westonpace
Copy link
Member

@westonpace westonpace commented Apr 3, 2023 •
edited by github-actions bot
Loading

Rationale for this change

The nightly test is currently failing with an error:

-- Found GTest: /usr/lib/cmake/GTest/GTestConfig.cmake (found suitable version "1.11.0", minimum required is "1.10.0")  
CMake Error at cmake_modules/ThirdpartyToolchain.cmake:2236 (message):
  System GTest is built with a C++ standard lower than 17.  Use bundled GTest
  via passing in CMake flag

  -DGTest_SOURCE="BUNDLED"

What changes are included in this PR?

Changes the alpine linux nightly test to use -DGTest_SOURCE="BUNDLED"

Are these changes tested?

Yes, by the nightly test itself.

Are there any user-facing changes?

No

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

⚠️ GitHub issue #34869 has been automatically assigned in GitHub to PR creator.

@westonpace
Copy link
Member Author

westonpace commented Apr 3, 2023

@github-actions crossbow submit test-alpine-linux-cpp

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Apr 3, 2023
@westonpace westonpace mentioned this pull request Apr 3, 2023
Merged
@github-actions
Copy link

github-actions bot commented Apr 3, 2023

Revision: 4b0869f

Submitted crossbow builds: ursacomputing/crossbow @ actions-914e7e5a7e

Task Status
test-alpine-linux-cpp Github Actions

kou
kou reviewed Apr 3, 2023
View reviewed changes
docker-compose.yml Outdated
Comment on lines 226 to 227
GTest_SOURCE: "BUNDLED" # Alpine's GTest is not built against
# C++17 so we build from source
Copy link
Member

@kou kou Apr 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this to ci/docker/alpine-linux-3.16-cpp.dockerfile like other *_SOURCE=BUNDLED?

Copy link
Member Author

@westonpace westonpace Apr 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I have done this.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Apr 3, 2023
@westonpace
Copy link
Member Author

westonpace commented Apr 4, 2023

@github-actions crossbow submit test-alpine-linux-cpp

@github-actions github-actions bot added awaiting change review Awaiting change review awaiting changes Awaiting changes and removed awaiting changes Awaiting changes awaiting change review Awaiting change review labels Apr 4, 2023
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

Revision: 667fc10

Submitted crossbow builds: ursacomputing/crossbow @ actions-5e6bf86d81

Task Status
test-alpine-linux-cpp Github Actions

kou
kou approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou merged commit 3927a6f into apache:main Apr 5, 2023
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting changes Awaiting changes labels Apr 5, 2023
@ursabot
Copy link

ursabot commented Apr 5, 2023

Benchmark runs are scheduled for baseline = 379c1fb and contender = 3927a6f. 3927a6f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Finished ⬇️0.26% ⬆️0.0%] ursa-i9-9960x
[Failed ⬇️0.0% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 3927a6f1 ec2-t3-xlarge-us-east-2
[Failed] 3927a6f1 test-mac-arm
[Finished] 3927a6f1 ursa-i9-9960x
[Failed] 3927a6f1 ursa-thinkcentre-m75q
[Finished] 379c1fb0 ec2-t3-xlarge-us-east-2
[Failed] 379c1fb0 test-mac-arm
[Finished] 379c1fb0 ursa-i9-9960x
[Failed] 379c1fb0 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@westonpace @ArgusLi
apacheGH-34869: [C++] Configure alpine linux nightly job to build gte…
68c1b6e 
…st from source (apache#34870)

### Rationale for this change

The nightly test is currently failing with an error:

```
-- Found GTest: /usr/lib/cmake/GTest/GTestConfig.cmake (found suitable version "1.11.0", minimum required is "1.10.0")  
CMake Error at cmake_modules/ThirdpartyToolchain.cmake:2236 (message):
  System GTest is built with a C++ standard lower than 17.  Use bundled GTest
  via passing in CMake flag

  -DGTest_SOURCE="BUNDLED"
```

### What changes are included in this PR?

Changes the alpine linux nightly test to use `-DGTest_SOURCE="BUNDLED"`

### Are these changes tested?

Yes, by the nightly test itself.

### Are there any user-facing changes?

No
* Closes: apache#34869

Authored-by: Weston Pace <weston.pace@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou kou approved these changes

@assignUser assignUser Awaiting requested review from assignUser assignUser is a code owner

@raulcd raulcd Awaiting requested review from raulcd raulcd is a code owner

Assignees

No one assigned

Labels

awaiting merge Awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[C++] Alpine linux nightly job is failing due to an invalid gtest

3 participants

@westonpace @ursabot @kou