Skip to content

GH-34861: [C++] Move GTest std version check into SYSTEM if branch #34874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kou merged 1 commit into from
Apr 4, 2023
Merged

GH-34861: [C++] Move GTest std version check into SYSTEM if branch #34874

kou merged 1 commit into from
Apr 4, 2023

Conversation

@HaochengLIU
Copy link
Contributor

@HaochengLIU HaochengLIU commented Apr 4, 2023 •
edited
Loading

Rationale for this change

Developers have reported that the current GTest std version check will break cpp microbenchmarks in BUNDLE mode.

What changes are included in this PR?

Move the check into SYSTEM if branch so that it gets triggered in a narrowed scope.

Are these changes tested?

Tested locally and will be covered by CI.

Are there any user-facing changes?

No

@HaochengLIU
apacheGH-34861: [C++] Move GTest std version check into SYSTEM if branch
2330330 
### Rationale for this change
Developers have reported that the current GTest std version check
will break cpp microbenchmarks in BUNDLE mode.

### What changes are included in this PR?
Move the check into SYSTEM if branch so that it gets triggered in a
narrowed scope.

### Are these changes tested?
Tested locally and will be covered by CI.

Are there any user-facing changes?
No
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

@github-actions
Copy link

github-actions bot commented Apr 4, 2023

⚠️ GitHub issue #34861 has been automatically assigned in GitHub to PR creator.

@HaochengLIU HaochengLIU mentioned this pull request Apr 4, 2023
Closed
@HaochengLIU
Copy link
Contributor Author

HaochengLIU commented Apr 4, 2023

I dont believe the failing tests are related to my change. More like corrupted build farm.

kou
kou approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

This will not solve #34861 but I merge this because this is a right change.
Our bundled GoogleTest must be built with the same C++ standard as Arrow C++ because we specify -DCMAKE_CXX_STANDARD=${CMAKE_CXX_STANDARD} via EP_COMMON_CMAKE_ARGS.
But build_gtest doesn't set INTERFACE_COMPILE_FEATURES. So the check is meaningless for bundled GoogleTest.

@kou kou merged commit 19c3260 into apache:main Apr 4, 2023
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Apr 4, 2023
@ursabot
Copy link

ursabot commented Apr 4, 2023

Benchmark runs are scheduled for baseline = 84ac7d5 and contender = 19c3260. 19c3260 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.56% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Failed ⬇️0.0% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 19c32606 ec2-t3-xlarge-us-east-2
[Failed] 19c32606 test-mac-arm
[Finished] 19c32606 ursa-i9-9960x
[Failed] 19c32606 ursa-thinkcentre-m75q
[Finished] 84ac7d5b ec2-t3-xlarge-us-east-2
[Failed] 84ac7d5b test-mac-arm
[Finished] 84ac7d5b ursa-i9-9960x
[Failed] 84ac7d5b ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@HaochengLIU HaochengLIU mentioned this pull request Apr 4, 2023
Merged
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@HaochengLIU @ArgusLi
apacheGH-34861: [C++] Move GTest std version check into SYSTEM if bra…
0feb82d 
…nch (apache#34874)

### Rationale for this change
Developers have reported that the current GTest std version check will break cpp microbenchmarks in BUNDLE mode.

### What changes are included in this PR?
Move the check into SYSTEM if branch so that it gets triggered in a narrowed scope.

### Are these changes tested?
Tested locally and will be covered by CI.

### Are there any user-facing changes?
No

* Closes: apache#34861

Authored-by: Haocheng Liu <lbtinglb@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kou kou kou approved these changes

Assignees

No one assigned

Labels

awaiting merge Awaiting merge Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Benchmarks] All cpp microbenchmarks are failing with new GTest CMake Error

3 participants

@HaochengLIU @ursabot @kou