Skip to content

GH-34930: [C++] Standardize aggregation column order #34931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
icexelloss merged 1 commit into from
Apr 14, 2023
Merged

GH-34930: [C++] Standardize aggregation column order #34931

icexelloss merged 1 commit into from
Apr 14, 2023

Conversation

@rtpsw
Copy link
Contributor

@rtpsw rtpsw commented Apr 6, 2023 •
edited
Loading

@rtpsw rtpsw requested a review from westonpace as a code owner April 6, 2023 12:45
@rtpsw
Copy link
Contributor Author

rtpsw commented Apr 6, 2023

cc @icexelloss

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

⚠️ GitHub issue #34930 has been automatically assigned in GitHub to PR creator.

icexelloss
icexelloss approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@icexelloss icexelloss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@icexelloss
Copy link
Contributor

icexelloss commented Apr 10, 2023

@westonpace This one looks good to me. Let me know if this looks good to you.

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Apr 10, 2023
@icexelloss
Copy link
Contributor

icexelloss commented Apr 11, 2023

Gentle ping @westonpace - can you please take a look if you have time? (in case you missed this)

@icexelloss
Copy link
Contributor

icexelloss commented Apr 14, 2023

@westonpace Since this is a pretty straight forward change and this has been agreed on in the issue:

#34908 (comment)

and I haven't heard back from you. I am going to merge this. If you have some requests for changes we can address as follow up.

@icexelloss icexelloss merged commit 5c73973 into apache:main Apr 14, 2023
@westonpace westonpace mentioned this pull request Apr 14, 2023
Closed
@westonpace
Copy link
Member

westonpace commented Apr 14, 2023

and I haven't heard back from you. I am going to merge this. If you have some requests for changes we can address as follow up.

That's fine. I'm sorry I didn't get to this earlier. I've been heads down this week on resolving 12.0.0 blockers and fallen behind on some reviews.

@rtpsw rtpsw deleted the GH-34930 branch April 15, 2023 12:00
@ursabot
Copy link

ursabot commented Apr 17, 2023

Benchmark runs are scheduled for baseline = 3f5457d and contender = 5c73973. 5c73973 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Finished ⬇️8.93% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.25% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 5c73973a ec2-t3-xlarge-us-east-2
[Failed] 5c73973a test-mac-arm
[Finished] 5c73973a ursa-i9-9960x
[Finished] 5c73973a ursa-thinkcentre-m75q
[Finished] 3f5457df ec2-t3-xlarge-us-east-2
[Failed] 3f5457df test-mac-arm
[Finished] 3f5457df ursa-i9-9960x
[Finished] 3f5457df ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Apr 17, 2023

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
@rtpsw @liujiacheng777
apacheGH-34930: [C++] Standardize aggregation column order (apache#34931
6b85ec0 
)

See apache#34930, apache#34908
* Closes: apache#34930
* Closes: apache#34908

Authored-by: Yaron Gvili <rtpsw@hotmail.com>
Signed-off-by: Li Jin <ice.xelloss@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@rtpsw @ArgusLi
apacheGH-34930: [C++] Standardize aggregation column order (apache#34931
eb879c6 
)

See apache#34930, apache#34908
* Closes: apache#34930
* Closes: apache#34908

Authored-by: Yaron Gvili <rtpsw@hotmail.com>
Signed-off-by: Li Jin <ice.xelloss@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icexelloss icexelloss icexelloss approved these changes

@westonpace westonpace Awaiting requested review from westonpace westonpace is a code owner

Assignees

No one assigned

Labels

awaiting merge Awaiting merge Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[C++] Standardize aggregation column order [C++] Switching the column ordering of "segment key" and "hash key"

4 participants

@rtpsw @icexelloss @westonpace @ursabot