Skip to content

GH-34966: [Go] Add InsertField and FieldIndex to Schema object #34967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yevgenypats wants to merge 2 commits into from
Closed

GH-34966: [Go] Add InsertField and FieldIndex to Schema object #34967

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9e95c5
GH-34966: Add InsertField and FieldIndex to Schema object
yevgenypats Apr 7, 2023
2a9db68
remove duplicate
yevgenypats Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions go/arrow/schema.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,16 @@ func (sc *Schema) FieldIndices(n string) []int {
return sc.index[n]
}

// FieldIndex return index of the unique field with the given name.
Copy link
Member

@zeroshade zeroshade Apr 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: returns the index

Also, is there a reason to have this in addition to the existing FieldIndices method? A consumer could just do the same length check and use index 0 themselves.

// Returns -1 if the name isn’t found or there are several fields with the given name.
func (sc *Schema) FieldIndex(name string) int {
indices := sc.index[name]
if len(indices) != 1 {
return -1
}
return indices[0]
}

func (sc *Schema) HasField(n string) bool { return len(sc.FieldIndices(n)) > 0 }
func (sc *Schema) HasMetadata() bool { return len(sc.meta.keys) > 0 }

Expand Down
9 changes: 9 additions & 0 deletions go/arrow/schema_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,15 @@ func TestSchema(t *testing.T) {
}
}

if s.FieldIndex("dup") != -1 {
t.Fatalf("invalid FieldIndex(dup): got=%d, want=-1", s.FieldIndex("dup"))
}
if s.HasField("f1") {
if s.FieldIndex("f1") != 0 {
t.Fatalf("invalid FieldIndex(f1): got=%d, want=0", s.FieldIndex("f1"))
}
}

if got, want := s.String(), tc.serialize; got != want {
t.Fatalf("invalid stringer: got=%q, want=%q", got, want)
}
Expand Down