Skip to content

GH-35073: [R] Minimal build is failing (acero symbol not defined) #35074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
assignUser merged 2 commits into from
Apr 12, 2023
Merged

GH-35073: [R] Minimal build is failing (acero symbol not defined) #35074

assignUser merged 2 commits into from
Apr 12, 2023

Conversation

@thisisnic
Copy link
Member

@thisisnic thisisnic commented Apr 12, 2023 •
edited by github-actions bot
Loading

This PR updates the decorator in a function introduced in #34685 which inadvertently referenced arrow and not acero.

@thisisnic thisisnic requested a review from paleolimbot as a code owner April 12, 2023 13:24
@github-actions
Copy link

github-actions bot commented Apr 12, 2023

@thisisnic
Copy link
Member Author

thisisnic commented Apr 12, 2023

@github-actions crossbow submit test-r-minimal-build

@github-actions github-actions bot added the awaiting committer review Awaiting committer review label Apr 12, 2023
@github-actions
Copy link

github-actions bot commented Apr 12, 2023

Revision: d5373b9

Submitted crossbow builds: ursacomputing/crossbow @ actions-21ed3a1c52

Task Status
test-r-minimal-build Azure

assignUser
assignUser approved these changes Apr 12, 2023
View reviewed changes
Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@assignUser assignUser merged commit c4312ea into apache:main Apr 12, 2023
@ursabot
Copy link

ursabot commented Apr 14, 2023

Benchmark runs are scheduled for baseline = 49e60a0 and contender = c4312ea. c4312ea is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Finished ⬇️1.79% ⬆️0.26%] ursa-i9-9960x
[Finished ⬇️0.95% ⬆️0.03%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] c4312ea4 ec2-t3-xlarge-us-east-2
[Failed] c4312ea4 test-mac-arm
[Finished] c4312ea4 ursa-i9-9960x
[Finished] c4312ea4 ursa-thinkcentre-m75q
[Finished] 49e60a0d ec2-t3-xlarge-us-east-2
[Failed] 49e60a0d test-mac-arm
[Finished] 49e60a0d ursa-i9-9960x
[Finished] 49e60a0d ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Apr 14, 2023

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

@nealrichardson nealrichardson mentioned this pull request Apr 19, 2023
Open
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
@thisisnic @liujiacheng777
apacheGH-35073: [R] Minimal build is failing (acero symbol not define…
60534c6 
…d) (apache#35074)

This PR updates the decorator in a function introduced in apache#34685 which inadvertently referenced `arrow` and not `acero`.
* Closes: apache#35073

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@thisisnic @ArgusLi
apacheGH-35073: [R] Minimal build is failing (acero symbol not define…
a8f71a4 
…d) (apache#35074)

This PR updates the decorator in a function introduced in apache#34685 which inadvertently referenced `arrow` and not `acero`.
* Closes: apache#35073

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@assignUser assignUser assignUser approved these changes

@paleolimbot paleolimbot Awaiting requested review from paleolimbot

Assignees

No one assigned

Labels

awaiting committer review Awaiting committer review Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[R] Minimal build is failing (acero symbol not defined)

3 participants

@thisisnic @ursabot @assignUser