Skip to content

GH-35059: [C++] Fix "hash_count" for run-end encoded inputs #35129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
westonpace merged 11 commits into from
May 1, 2023
Merged

GH-35059: [C++] Fix "hash_count" for run-end encoded inputs #35129

westonpace merged 11 commits into from
May 1, 2023

Conversation

@felipecrv
Copy link
Contributor

@felipecrv felipecrv commented Apr 14, 2023 •
edited
Loading

Rationale for this change

Fixing a bug.

What changes are included in this PR?

Changes to the "hash_count" kernel implementation to handle REE and union arrays correctly.

  • Generic (potentially slow) implementation
  • REE-specialized implementation

Are these changes tested?

Yes, by modifying the existing unit tests.

@github-actions
Copy link

github-actions bot commented Apr 14, 2023

@github-actions
Copy link

github-actions bot commented Apr 14, 2023

⚠️ GitHub issue #35059 has been automatically assigned in GitHub to PR creator.

@felipecrv felipecrv force-pushed the fix_count_null_handling branch 2 times, most recently from af5e2cb to 647d510 Compare April 14, 2023 22:54
@felipecrv felipecrv marked this pull request as ready for review April 18, 2023 13:31
@felipecrv felipecrv requested a review from westonpace as a code owner April 18, 2023 13:31
@felipecrv felipecrv marked this pull request as draft April 18, 2023 13:31
@felipecrv felipecrv force-pushed the fix_count_null_handling branch from 760dc0b to 6c3f090 Compare April 18, 2023 17:40
@felipecrv felipecrv marked this pull request as ready for review April 18, 2023 19:07
@felipecrv
Copy link
Contributor Author

felipecrv commented Apr 18, 2023

@westonpace @jorisvandenbossche

westonpace
westonpace requested changes Apr 27, 2023
View reviewed changes
Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit for consistency in test routines to only use EXPECT if not returning a statusy thing.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Apr 27, 2023
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Apr 28, 2023
westonpace
westonpace approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for also extending the test to cover all the options as well.

@westonpace westonpace merged commit be12888 into apache:main May 1, 2023
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting change review Awaiting change review labels May 1, 2023
@ursabot
Copy link

ursabot commented May 2, 2023

Benchmark runs are scheduled for baseline = 99ac74e and contender = be12888. be12888 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️3.03% ⬆️0.26%] test-mac-arm
[Failed ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️1.11% ⬆️0.06%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] be128889 ec2-t3-xlarge-us-east-2
[Failed] be128889 test-mac-arm
[Failed] be128889 ursa-i9-9960x
[Finished] be128889 ursa-thinkcentre-m75q
[Finished] 99ac74e6 ec2-t3-xlarge-us-east-2
[Failed] 99ac74e6 test-mac-arm
[Failed] 99ac74e6 ursa-i9-9960x
[Finished] 99ac74e6 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented May 2, 2023

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm

@felipecrv felipecrv deleted the fix_count_null_handling branch May 10, 2023 14:38
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
@felipecrv @liujiacheng777
apacheGH-35059: [C++] Fix "hash_count" for run-end encoded inputs (ap…
db74d2a 
…ache#35129)

### Rationale for this change

Fixing a bug.

### What changes are included in this PR?

Changes to the `"hash_count"` kernel implementation to handle REE and union arrays correctly.

- [x] Generic (potentially slow) implementation
- [x] REE-specialized implementation

### Are these changes tested?

Yes, by modifying the existing unit tests.

* Closes: apache#35059

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@felipecrv @ArgusLi
apacheGH-35059: [C++] Fix "hash_count" for run-end encoded inputs (ap…
7ea89d2 
…ache#35129)

### Rationale for this change

Fixing a bug.

### What changes are included in this PR?

Changes to the `"hash_count"` kernel implementation to handle REE and union arrays correctly.

- [x] Generic (potentially slow) implementation
- [x] REE-specialized implementation

### Are these changes tested?

Yes, by modifying the existing unit tests.

* Closes: apache#35059

Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Signed-off-by: Weston Pace <weston.pace@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@westonpace westonpace westonpace approved these changes

Assignees

No one assigned

Labels

awaiting merge Awaiting merge Component: C++

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[C++] hash_count kernel miscounts when run-end encoded array contains null

3 participants

@felipecrv @ursabot @westonpace