Skip to content

GH-14946: [C++] Add flattening FieldPath/FieldRef::Get methods #35197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pitrou merged 21 commits into from
May 22, 2023
Merged

GH-14946: [C++] Add flattening FieldPath/FieldRef::Get methods #35197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
a0c2817
Implement FieldPath::GetFlattened methods
benibus Apr 17, 2023
4396f6c
Fix offset handling in ChunkedColumn::FlattenZeroCopy
benibus Apr 17, 2023
665c3dc
Revamp tests for FieldPath
benibus Apr 17, 2023
a1ba0df
Fix test segfault on java-jni-manylinux-2014
benibus Apr 18, 2023
db2c0d3
Implement flattened methods for FieldRef
benibus Apr 18, 2023
971ce4e
Use internal helpers in FieldPath tests
benibus Apr 18, 2023
8b6aea4
Remove redundant FieldPath test
benibus Apr 18, 2023
78ca0ba
Implement NestedSelector for FieldPathGetImpl
benibus May 1, 2023
918b083
Support passing MemoryPool to GetFlattenedField
benibus May 1, 2023
0168b70
Minor naming fix
benibus May 1, 2023
44bf768
Apply comment suggestion
benibus May 15, 2023
015c2fd
Remove FieldRef::Get indirections
benibus May 15, 2023
08ce6bd
Use `if constexpr` in FieldPathTestCase
benibus May 15, 2023
c9be785
Explain some weirdness in AssertOutputsEqual
benibus May 16, 2023
98d43ee
Test/fix IndexError message
benibus May 16, 2023
fb1d694
Add tests for FieldRef methods
benibus May 16, 2023
8ca8399
Test cleanup
benibus May 16, 2023
759523c
Return FieldPath::GetFlattened errors in FieldRef
benibus May 17, 2023
e09516e
Additional validation checks
benibus May 17, 2023
163ee85
Relocate FieldPath/Ref tests to new module
benibus May 17, 2023
a1662aa
Add docstrings for new methods
pitrou May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cpp/src/arrow/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -796,7 +796,7 @@ set_source_files_properties(public_api_test.cc PROPERTIES SKIP_PRECOMPILE_HEADER
SKIP_UNITY_BUILD_INCLUSION ON)

add_arrow_test(scalar_test)
add_arrow_test(type_test)
add_arrow_test(type_test SOURCES field_ref_test.cc type_test.cc)

add_arrow_test(table_test
SOURCES
Expand Down
Loading