Skip to content

GH-35131: [R] Test failure with dev waldo #35308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thisisnic merged 2 commits into from
Apr 26, 2023
Merged

GH-35131: [R] Test failure with dev waldo #35308

thisisnic merged 2 commits into from
Apr 26, 2023

Conversation

@thisisnic
Copy link
Member

@thisisnic thisisnic commented Apr 24, 2023 •
edited
Loading

This PR fixes the tests failing due to the dev version of the waldo package being more strict comparing NaN and NA_real_ values. (n.b. our CI doesn't yet use the dev version of waldo, so this PR should be tested locally to verify tests pass).

@github-actions
Copy link

github-actions bot commented Apr 24, 2023

@github-actions
Copy link

github-actions bot commented Apr 24, 2023

⚠️ GitHub issue #35131 has been automatically assigned in GitHub to PR creator.

@thisisnic thisisnic marked this pull request as ready for review April 24, 2023 19:48
@thisisnic thisisnic requested a review from paleolimbot as a code owner April 24, 2023 19:48
paleolimbot
paleolimbot approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@paleolimbot paleolimbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Apr 26, 2023
@thisisnic thisisnic merged commit 64bed71 into apache:main Apr 26, 2023
@ursabot
Copy link

ursabot commented Apr 26, 2023

Benchmark runs are scheduled for baseline = c38c778 and contender = 64bed71. 64bed71 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️1.08% ⬆️0.12%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 64bed71f ec2-t3-xlarge-us-east-2
[Failed] 64bed71f test-mac-arm
[Finished] 64bed71f ursa-i9-9960x
[Finished] 64bed71f ursa-thinkcentre-m75q
[Finished] c38c7788 ec2-t3-xlarge-us-east-2
[Failed] c38c7788 test-mac-arm
[Finished] c38c7788 ursa-i9-9960x
[Finished] c38c7788 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

thisisnic added a commit to thisisnic/arrow that referenced this pull request May 3, 2023
@thisisnic
apacheGH-35131: [R] Test failure with dev waldo (apache#35308)
27f86a8 
This PR fixes the tests failing due to the dev version of the waldo package being more strict comparing NaN and NA_real_ values.  (n.b. our CI doesn't yet use the dev version of waldo, so this PR should be tested locally to verify tests pass).
* Closes: apache#35131

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
@thisisnic @liujiacheng777
apacheGH-35131: [R] Test failure with dev waldo (apache#35308)
e992ea2 
This PR fixes the tests failing due to the dev version of the waldo package being more strict comparing NaN and NA_real_ values.  (n.b. our CI doesn't yet use the dev version of waldo, so this PR should be tested locally to verify tests pass).
* Closes: apache#35131

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@thisisnic @ArgusLi
apacheGH-35131: [R] Test failure with dev waldo (apache#35308)
781a01f 
This PR fixes the tests failing due to the dev version of the waldo package being more strict comparing NaN and NA_real_ values.  (n.b. our CI doesn't yet use the dev version of waldo, so this PR should be tested locally to verify tests pass).
* Closes: apache#35131

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
raulcd pushed a commit that referenced this pull request May 30, 2023
@thisisnic @raulcd
GH-35131: [R] Test failure with dev waldo (#35308)
9e95835 
This PR fixes the tests failing due to the dev version of the waldo package being more strict comparing NaN and NA_real_ values.  (n.b. our CI doesn't yet use the dev version of waldo, so this PR should be tested locally to verify tests pass).
* Closes: #35131

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paleolimbot paleolimbot paleolimbot approved these changes

Assignees

No one assigned

Labels

awaiting merge Awaiting merge Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[R] Test failure with dev waldo

3 participants

@thisisnic @ursabot @paleolimbot