-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-35180: [R] Implement bindings for cumsum function #35339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or In the case of PARQUET issues on JIRA the title also supports: See also: |
thisisnic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A tiny change needed to the tests, but otherwise this looks great! I'll make a few more minor changes to the PR title so it automatically links the right issue, and run the linter, and after that, this'll be good to go. Thanks for submitting this PR, @arnaud-feldmann!
|
|
|
Benchmark runs are scheduled for baseline = a5ac94e and contender = f6bda06. f6bda06 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
) Fixes apache#35180 Can't do the binding to dplyr, as dplyr takes Scalar Expressions and cumsum ( apache#12460 ) isn't a scalar expression. * Closes: apache#35180 Lead-authored-by: arnaud-feldmann <arnaud.feldmann@gmail.com> Co-authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
) Fixes apache#35180 Can't do the binding to dplyr, as dplyr takes Scalar Expressions and cumsum ( apache#12460 ) isn't a scalar expression. * Closes: apache#35180 Lead-authored-by: arnaud-feldmann <arnaud.feldmann@gmail.com> Co-authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
Fixes #35180
Can't do the binding to dplyr, as dplyr takes Scalar Expressions and cumsum ( #12460 ) isn't a scalar expression.