Skip to content

Conversation

@arnaud-feldmann
Copy link
Contributor

@arnaud-feldmann arnaud-feldmann commented Apr 25, 2023

Fixes #35180
Can't do the binding to dplyr, as dplyr takes Scalar Expressions and cumsum ( #12460 ) isn't a scalar expression.

@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

Copy link
Member

@thisisnic thisisnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A tiny change needed to the tests, but otherwise this looks great! I'll make a few more minor changes to the PR title so it automatically links the right issue, and run the linter, and after that, this'll be good to go. Thanks for submitting this PR, @arnaud-feldmann!

@thisisnic thisisnic changed the title [R] Implement cumsum for Arrays GH-35180: [R] Implement bindings for cumsum function Apr 26, 2023
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Apr 26, 2023
@github-actions
Copy link

@github-actions
Copy link

⚠️ GitHub issue #35180 has been automatically assigned in GitHub to PR creator.

@thisisnic thisisnic merged commit f6bda06 into apache:main Apr 26, 2023
@ursabot
Copy link

ursabot commented Apr 26, 2023

Benchmark runs are scheduled for baseline = a5ac94e and contender = f6bda06. f6bda06 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.15% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] f6bda06f ec2-t3-xlarge-us-east-2
[Failed] f6bda06f test-mac-arm
[Finished] f6bda06f ursa-i9-9960x
[Finished] f6bda06f ursa-thinkcentre-m75q
[Finished] a5ac94e5 ec2-t3-xlarge-us-east-2
[Failed] a5ac94e5 test-mac-arm
[Finished] a5ac94e5 ursa-i9-9960x
[Finished] a5ac94e5 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
)

Fixes apache#35180 
Can't do the binding to dplyr, as dplyr takes Scalar Expressions and cumsum ( apache#12460 ) isn't a scalar expression.
* Closes: apache#35180

Lead-authored-by: arnaud-feldmann <arnaud.feldmann@gmail.com>
Co-authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
)

Fixes apache#35180 
Can't do the binding to dplyr, as dplyr takes Scalar Expressions and cumsum ( apache#12460 ) isn't a scalar expression.
* Closes: apache#35180

Lead-authored-by: arnaud-feldmann <arnaud.feldmann@gmail.com>
Co-authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[R] Implement bindings for cumsum function

3 participants