-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-32282: [R] Update case_when() binding to match changes in dplyr #35502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
We could implement |
paleolimbot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Doesn't the note need to be described this way? arrow/r/R/dplyr-funcs-datetime.R Lines 81 to 84 in df5f67d
|
|
Benchmark runs are scheduled for baseline = dec4453 and contender = 1a038ad. 1a038ad is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
|
['Python', 'R'] benchmarks have high level of regressions. |
…lyr (apache#35502) This PR implements the `.default` argument for `case_when` and raises errors if non-NULL values are supplied for `.ptype` and `.size`. * Closes: apache#32282 Authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
This PR implements the
.defaultargument forcase_whenand raises errors if non-NULL values are supplied for.ptypeand.size.