-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-35627: [C++][Format][Integration] Add string view to the arrow format #35628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
6d490ef
Draft basic scaffolding for Binary/StringView types and get compiling
wesm 21688eb
BinaryViewBuilder: fix duplicate values in null bitmap
zagto 6b6cd95
enable JSON converter for StringView/BinaryView
zagto 52eb446
add StringView/BinaryView to AllTypeIds
zagto 8a75259
implement inline visitor for StringView/BinaryView
zagto 1d81aea
fix formatting
zagto 3931e25
fix formatting
zagto 7fe8e2d
run binary data visitor tests on StringView/BinaryView
zagto 6624acc
fixes in substrait, rename in LICENSE, owning scalars
bkietz 8511bf1
delete potentially internal viewing members for rvalues
bkietz 6df010f
Added validation for StringView arrays
bkietz 5c24fd5
Adding comparison and concatenation
bkietz 190648c
wrote <=, needed >=
bkietz 018b49f
Extract visitation of views owning buffers
bkietz 0ee9d89
add cast to/from string_view
bkietz 6ed4ac0
Adding IPC serde of views by converting to/from dense strings
bkietz a8bf258
initial attempt at indices/offsets repr in arrow
bkietz bfe16b3
formatting, compilation fixes
bkietz 1a01463
CI fixes
bkietz bdf7836
format python too
bkietz 80a8758
more casts
bkietz 4cd23f2
msvc: more casts
bkietz 2d93d97
Extend R converter with binary view support
bkietz 2c395c3
more casts
bkietz e626949
read/write hex encode prefix for string view too
bkietz 71db0dc
review comments re: Columnar.rst description
bkietz c961942
msvc: explicit unreachable switch default
bkietz 84f0723
r: exclude decimal from binary_like
bkietz 175baac
go impl isn't here... yet
bkietz b5196a6
add benchmarks for filter, take, sort
bkietz dd4a5be
clang-format
bkietz aaad04f
msvc: doesn't have constexpr conversion operator?
bkietz d71c223
try fix for opentelemetry build failure
bkietz 5f06a1c
review comments
bkietz def55c6
repair merge error
bkietz dddc3df
formatting again
bkietz fdda27c
DCHECK_EQ() not DCHECK(==)
bkietz 46cf7e6
add BinaryViewLike matcher
bkietz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.