ARROW-3814: [R] RecordBatch$from_arrays()#3565

Closed

romainfrancois wants to merge 21 commits intoapache:masterfrom

romainfrancois:ARROW-3814/record_batch_from_arrays

Commits on Jun 3, 2019

schema() supports tidy dots splicing, using rlang::list2
romainfrancois
committed
+ list_to_shared_ptr_vector
romainfrancois
committed
Change record_batch() api so that it takes ... and schema.
romainfrancois
committed
update docs
romainfrancois
committed
move the logic of `RecordBatch__from_arrays` internally.
romainfrancois
committed
retire RecordBatch__from_dataframe() function, no longer needed and replaced by RecordBatch__from_arrays()
romainfrancois
committed
table() factory also handles ... and !!! a schema, similar to record_batch()
romainfrancois
committed
table(...) cab now either handle ... being:
romainfrancois
committed
test for table(...<batches>)
romainfrancois
committed
tests for table(...<vectors, arrays, chunked arrays>)
romainfrancois
committed
use the schema= argument in table()
romainfrancois
committed
record_batch(..., schema = )
romainfrancois
committed
directly return from builder_->Finish(), as suggested here: https://github.com/apache/arrow/pull/3635/files/08b295370271f122b410b991282b4919510b5cea#r261012517
romainfrancois
committed
tests about record_batch(schema=) argument
romainfrancois
committed
STOP_IF migth be useful too
romainfrancois
committed
record_batch(schema=) compares names
romainfrancois
committed
add comments about !!!
romainfrancois
committed
typo
romainfrancois
committed
Also run cpplint and clang-format on .cpp files

wesm
authored and
romainfrancois
committed
rebase
romainfrancois
committed
only pass $1 to run_clang_format so that we can do:
romainfrancois
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ARROW-3814: [R] RecordBatch$from_arrays()#3565

ARROW-3814: [R] RecordBatch$from_arrays()#3565
romainfrancois wants to merge 21 commits intoapache:masterfrom
romainfrancois:ARROW-3814/record_batch_from_arrays

Commits on Jun 3, 2019

schema() supports tidy dots splicing, using rlang::list2

+ list_to_shared_ptr_vector

Change record_batch() api so that it takes ... and schema.

update docs

move the logic of `RecordBatch__from_arrays` internally.

retire RecordBatch__from_dataframe() function, no longer needed and replaced by RecordBatch__from_arrays()

table() factory also handles ... and !!! a schema, similar to record_batch()

table(...) cab now either handle ... being:

test for table(...<batches>)

tests for table(...<vectors, arrays, chunked arrays>)

use the schema= argument in table()

record_batch(..., schema = )

directly return from builder_->Finish(), as suggested here: https://github.com/apache/arrow/pull/3635/files/08b295370271f122b410b991282b4919510b5cea#r261012517

tests about record_batch(schema=) argument

STOP_IF migth be useful too

record_batch(schema=) compares names

add comments about !!!

typo

Also run cpplint and clang-format on .cpp files

rebase

only pass $1 to run_clang_format so that we can do: