Skip to content

GH-36176: [C++] Fix regression for single-key Table sorting #36179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pitrou merged 1 commit into from
Jun 20, 2023
Merged

GH-36176: [C++] Fix regression for single-key Table sorting #36179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions cpp/src/arrow/compute/kernels/vector_sort.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1012,6 +1012,17 @@ class SortIndicesMetaFunction : public MetaFunction {
if (n_sort_keys == 0) {
return Status::Invalid("Must specify one or more sort keys");
}
if (n_sort_keys == 1) {
// The single-key approach here differs from the record batch one as pre-resolving
// the table sort keys involves processing the table into batches, which we don't
// need to do here.
ARROW_ASSIGN_OR_RAISE(
auto chunked_array,
PrependInvalidColumn(options.sort_keys[0].target.GetOneFlattened(table)));
if (chunked_array->type()->id() != Type::STRUCT) {
return SortIndices(*chunked_array, options, ctx);
}
}

auto out_type = uint64();
auto length = table.num_rows();
Expand Down