Skip to content

Conversation

@rtpsw
Copy link
Contributor

@rtpsw rtpsw commented Jun 28, 2023

Rationale for this change

Skipping a flaky test until a robust way for it is found.

What changes are included in this PR?

The AsofJoinTest.BackpressureWithBatchesGen test is skipped.

Are these changes tested?

N/A

Are there any user-facing changes?

No.

@github-actions
Copy link

⚠️ GitHub issue #36311 has been automatically assigned in GitHub to PR creator.

@rtpsw
Copy link
Contributor Author

rtpsw commented Jun 28, 2023

cc @icexelloss, @pitrou, @bkietz, @kou

@github-actions github-actions bot added the awaiting review Awaiting review label Jun 28, 2023
@pitrou pitrou changed the title GH-36311: [C++][CI] Sporadic errors in GH-36311: [C++][CI] Sporadic errors in AsofJoinTest Jun 28, 2023
@pitrou
Copy link
Member

pitrou commented Jun 28, 2023

@rtpsw Looks like you mentioned the wrong issue number in the PR description?

@github-actions
Copy link

⚠️ GitHub issue #36311 has been automatically assigned in GitHub to PR creator.

@pitrou pitrou changed the title GH-36311: [C++][CI] Sporadic errors in AsofJoinTest GH-36331: [C++][CI] Sporadic errors in AsofJoinTest Jun 28, 2023
@github-actions
Copy link

⚠️ GitHub issue #36331 has been automatically assigned in GitHub to PR creator.

@kou
Copy link
Member

kou commented Jun 28, 2023

Are the followings correct?

@rtpsw
Copy link
Contributor Author

rtpsw commented Jun 29, 2023

Yes, this is my understanding of this post.

@kou
Copy link
Member

kou commented Jun 29, 2023

I see. I'll merge this.

@kou kou merged commit 5cc6aa3 into apache:main Jun 29, 2023
@kou kou removed the awaiting review Awaiting review label Jun 29, 2023
@conbench-apache-arrow
Copy link

Conbench analyzed the 5 benchmark runs on commit 5cc6aa35.

There were 8 benchmark results indicating a performance regression:

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[C++][CI] Sporadic errors in arrow-acero-asof-join-node-test

3 participants