ARROW-574: Python: Add support for nested Python lists in Pandas conversion #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhochy
commented
Mar 8, 2017
Member
Author
There was a problem hiding this comment.
I'm not sure if we should maybe acquire the GIL always in this function instead of only for pylists.
Contributor
There was a problem hiding this comment.
+1 Note were calling PyList_Check just before we acquire the GIL
tebeka
reviewed
Mar 9, 2017
Contributor
There was a problem hiding this comment.
Do we want to allow implicit conversion (like int32 to int64)?
Member
Author
There was a problem hiding this comment.
We may allow this in future but currently we are missing a matching converter or alternatively, a convenient cast function for other integer types.
jeffknupp
pushed a commit
to jeffknupp/arrow
that referenced
this pull request
Mar 15, 2017
…ersion Author: Uwe L. Korn <uwelk@xhochy.com> Closes apache#364 from xhochy/ARROW-574 and squashes the following commits: 3ef02ae [Uwe L. Korn] ARROW-574: Python: Add support for nested Python lists in Pandas conversion
wesm
added a commit
to wesm/arrow
that referenced
this pull request
Sep 8, 2018
…-1154 I verified locally that this works on Linux with the current iteration of apache#785, will update the commit in ThirdpartyToolchain.cmake after that is merged to get a passing build Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#364 from wesm/PARQUET-1045 and squashes the following commits: fede8d9 [Wes McKinney] Update Arrow version to include ARROW-1159 b44b4ab [Wes McKinney] Fix benchmark. Only build Zlib on Windows when building Thrift 83d2289 [Wes McKinney] Update Arrow version 8914c16 [Wes McKinney] Remove code that was moved to Apache Arrow, refactoring Change-Id: Ibee94d0dd9d0b6844bdbb3c57da5126c97760108
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.