-
Notifications
You must be signed in to change notification settings - Fork 4k
GH-36469: [Java][Packaging] Distribute linux aarch64 libs with mavencentral jars #36487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-36469: [Java][Packaging] Distribute linux aarch64 libs with mavencentral jars #36487
Conversation
|
|
|
@github-actions crossbow submit java-jars |
|
I don't expect the job for java-jars to succeed as it is currently failing on main but seeing the logs might helps us move forward the PR. Thanks for the PR @jonathanswenson ! |
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit java-jars |
|
^^ not sure If i'm allowed to do that (or if github-actions will listen to me here), but want to see if the env variables I set worked here. Edit: looks like no. |
|
|
@github-actions crossbow submit java-jars |
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit java-jars |
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit java-jars |
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit java-jars |
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit java-jars |
This comment was marked as outdated.
This comment was marked as outdated.
|
@github-actions crossbow submit java-jars |
|
Revision: 2d0f8eb Submitted crossbow builds: ursacomputing/crossbow @ actions-5a980405bf
|
|
This is ready now. |
|
IIRC this should not require any changes to the release scripts for the new binaries to be included in the upload to maven right? Otherwise +1 from me :D |
|
Right. Existing packages just include binaries created by this PR. No new packages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jonathanswenson and @kou !
I'll create an issue to review the test exclusions once #36482 is merged
edit: link to the issue except of PR
|
I've created this issue to follow the removal of the excluded tests here: apache/arrow-java#183 |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 6f6d9ff. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
My primary concern here is whether or not I need to avoid pushing the docker image when using aarch64.
Perhaps with a conditional check on arch line 52 of
dev/tasks/java-jars/github.ymlRationale for this change
The java libraries distributed on maven central do not include native libraries build for linux/aarch64, this change should build and include those native libraries in the distribution.
Are these changes tested?
No additional tests are added, but only introduces changes for the build process.
Are there any user-facing changes?
Should not be any user-facing change except for support for the linux/arm64 architecture when pulling java libs from mavencentral.