Skip to content

ARROW-4571: [Format] Tensor.fbs file has multiple root_type declarations #3651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mrkn wants to merge 2 commits into from
Closed

ARROW-4571: [Format] Tensor.fbs file has multiple root_type declarations #3651

mrkn wants to merge 2 commits into from

Conversation

@mrkn
Copy link
Member

@mrkn mrkn commented Feb 14, 2019

No description provided.

@mrkn mrkn force-pushed the separate_sparse_tensor_format branch 2 times, most recently from f82511b to fdae20e Compare February 15, 2019 00:49
@mrkn mrkn force-pushed the separate_sparse_tensor_format branch from fdae20e to 77ab74d Compare February 15, 2019 07:33
@mrkn mrkn force-pushed the separate_sparse_tensor_format branch from 77ab74d to 760cefa Compare February 17, 2019 05:34
@codecov-io
Copy link

codecov-io commented Feb 17, 2019

Codecov Report

Merging #3651 into master will increase coverage by 0.84%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3651      +/-   ##
==========================================
+ Coverage   87.78%   88.62%   +0.84%     
==========================================
  Files         689      560     -129     
  Lines       84023    75026    -8997     
  Branches     1081        0    -1081     
==========================================
- Hits        73757    66493    -7264     
+ Misses      10151     8533    -1618     
+ Partials      115        0     -115
Impacted Files Coverage Δ
cpp/src/arrow/ipc/metadata-internal.cc 90.79% <ø> (ø) ⬆️
go/arrow/math/uint64_amd64.go
go/arrow/memory/memory_avx2_amd64.go
js/src/enum.ts
go/arrow/array/builder.go
js/src/Arrow.node.ts
js/src/schema.ts
go/arrow/type_traits_boolean.go
js/src/ipc/node/writer.ts
js/src/visitor/vectorloader.ts
... and 120 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c340b4...760cefa. Read the comment docs.

@mrkn mrkn changed the title ARROW-4571: [WIP][Format] Tensor.fbs file has multiple root_type declarations ARROW-4571: [Format] Tensor.fbs file has multiple root_type declarations Feb 17, 2019
@mrkn
Copy link
Member Author

mrkn commented Feb 17, 2019

@wesm This is ready to be merged.

wesm
wesm approved these changes Feb 18, 2019
View reviewed changes
Copy link
Member

@wesm wesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Thank you @mrkn!

@wesm wesm closed this in 2df33de Feb 18, 2019
@mrkn mrkn deleted the separate_sparse_tensor_format branch April 25, 2019 06:15
@asfimport asfimport mentioned this pull request Feb 18, 2019
Closed
pribor pushed a commit to GlobalWebIndex/arrow that referenced this pull request Oct 24, 2025
@mrkn @kou
ARROW-4571: [Format] Tensor.fbs file has multiple root_type declarations
d1f33ee 
Author: Kenta Murata <mrkn@mrkn.jp>

Closes apache#3651 from mrkn/separate_sparse_tensor_format and squashes the following commits:

760cefa <Kenta Murata> Add format/SparseTensor.fbs
1f92cfa <Kenta Murata> Separate SaprseTensor.fbs from Tensor.fbs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesm wesm wesm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mrkn @codecov-io @wesm