GH-36812: [C#] Fix C API support to work with .NET desktop framework #36813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
westonpace
added
Priority: Blocker
westonpace
reviewed
Jul 21, 2023
Member
westonpace
left a comment
westonpace
left a comment
There was a problem hiding this comment.
Can we create a follow-up issue for adding 4.7.2 to some kind of CI (I think this means we need to resolve the tests hanging issue)?
github-actions
bot
added
awaiting changes
Contributor
Author
|
I don't know offhand what targeting net472 will do on non-Windows platforms... |
github-actions
bot
added
awaiting change review
Contributor
Author
|
Yeah, judging by CI failures we can't just enable net472 in the test project. I don't see a way to turn those on for just Windows. |
westonpace
approved these changes
Jul 21, 2023
raulcd
pushed a commit
that referenced
this pull request
Jul 24, 2023
…36813) The C API support in the C# library has been modified to work correctly on .NET 4.7.2. The tests have been modified to work correctly on .NET 4.7.2, though that platform is disabled by default as the Python interop seem to cause a hang when unloading the xUnit AppDomain. **This PR contains a "Critical Fix".** * Closes: #36812 Authored-by: Curt Hagenlocher <curt@hagenlocher.org> Signed-off-by: Weston Pace <weston.pace@gmail.com>
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit b557e85. There were 3 benchmark results indicating a performance regression:
The full Conbench report has more details. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…ework (apache#36813) ### What changes are included in this PR? The C API support in the C# library has been modified to work correctly on .NET 4.7.2. The tests have been modified to work correctly on .NET 4.7.2, though that platform is disabled by default as the Python interop seem to cause a hang when unloading the xUnit AppDomain. **This PR contains a "Critical Fix".** * Closes: apache#36812 Authored-by: Curt Hagenlocher <curt@hagenlocher.org> Signed-off-by: Weston Pace <weston.pace@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
The C API support in the C# library has been modified to work correctly on .NET 4.7.2.
The tests have been modified to work correctly on .NET 4.7.2, though that platform is disabled by default as the Python interop seem to cause a hang when unloading the xUnit AppDomain.
This PR contains a "Critical Fix".