Skip to content

GH-15017: [Python] Harden test_memory.py for use with ARROW_USE_GLOG=ON #36901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 3 commits into from
Jul 28, 2023
Merged

GH-15017: [Python] Harden test_memory.py for use with ARROW_USE_GLOG=ON #36901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0fbddf
harden test_memory.py for use with ARROW_USE_GLOG=ON
h-vetinari Jul 27, 2023
9e394b2
fix typo
h-vetinari Jul 27, 2023
a578195
Fix lint
kou Jul 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions dev/tasks/conda-recipes/arrow-cpp/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,8 +403,6 @@ outputs:
{% set tests_to_skip = tests_to_skip + " or test_safe_cast_from_float_with_nans_to_int" %} # [ppc64le]
# gandiva tests are segfaulting on ppc
{% set tests_to_skip = tests_to_skip + " or test_float_with_null_as_integer" %} # [ppc64le]
# "Unsupported backend 'nonexistent' specified in ARROW_DEFAULT_MEMORY_POOL"
{% set tests_to_skip = tests_to_skip + " or (test_memory and test_env_var)" %} # [unix]
# test is broken; header is in $PREFIX, not $SP_DIR
{% set tests_to_skip = tests_to_skip + " or (test_misc and test_get_include)" %} # [unix]
# flaky tests that fail occasionally
Expand Down
10 changes: 8 additions & 2 deletions python/pyarrow/tests/test_memory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,14 @@ def check_env_var(name, expected, *, expect_warning=False):
res.check_returncode() # fail
errlines = res.stderr.splitlines()
if expect_warning:
assert len(errlines) == 1
assert f"Unsupported backend '{name}'" in errlines[0]
assert len(errlines) in (1, 2)
if len(errlines) == 1:
# ARROW_USE_GLOG=OFF
assert f"Unsupported backend '{name}'" in errlines[0]
else:
# ARROW_USE_GLOG=ON
assert "InitGoogleLogging()" in errlines[0]
assert f"Unsupported backend '{name}'" in errlines[1]
else:
assert len(errlines) == 0

Expand Down