GH-36323: [Python] Fix Timestamp scalar repr error on values outside datetime range #36942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@github-actions crossbow submit -g python |
|
Revision: 8e6def2 Submitted crossbow builds: ursacomputing/crossbow @ actions-6d5645c1ef
|
Contributor
Author
|
Will there need to be anything else I need to change, or is everything all set? |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 112f949. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…tside datetime range (apache#36942) ### Rationale for this change apache#36323 ### What changes are included in this PR? Changed the way repr is handled for TimestampScalar ### Are these changes tested? I have added a very basic test for this change to see whether it will error or not if outside the range. ### Are there any user-facing changes? The functionality of TimestampScalar's repr now uses the `strftime` function. * Closes: apache#36323 Lead-authored-by: Ashish Bailkeri <ashishbailkeri123@gmail.com> Co-authored-by: Ashish Bailkeri <47304318+aboss123@users.noreply.github.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
#36323
What changes are included in this PR?
Changed the way repr is handled for TimestampScalar
Are these changes tested?
I have added a very basic test for this change to see whether it will error or not if outside the range.
Are there any user-facing changes?
The functionality of TimestampScalar's repr now uses the
strftimefunction.