Skip to content

GH-37045: [MATLAB] Implement featherwrite in terms of arrow.internal.io.feather.Writer #37047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kevingurney merged 2 commits into from
Aug 7, 2023
Merged

GH-37045: [MATLAB] Implement featherwrite in terms of arrow.internal.io.feather.Writer #37047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2c0078b
Use the new feather Writer class in featherwrite.m
sgilmore10 Aug 7, 2023
beb79bf
Update the expectederror IDs in the feather tests
sgilmore10 Aug 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 6 additions & 16 deletions matlab/src/matlab/featherwrite.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,21 +23,11 @@ function featherwrite(filename, t)
% specific language governing permissions and limitations
% under the License.

import arrow.util.table2mlarrow;
arguments
filename(1, 1) string {mustBeNonmissing, mustBeNonzeroLengthText}
t table
end

% Validate input arguments.
narginchk(2, 2);
filename = convertStringsToChars(filename);
if ~ischar(filename)
error('MATLAB:arrow:InvalidFilenameDatatype', ...
'Filename must be a character vector or string scalar.');
end
if ~istable(t)
error('MATLAB:arrow:InvalidInputTable', 't must be a table.');
end

[variables, metadata] = table2mlarrow(t);

% Write the table to a Feather file.
arrow.cpp.call('featherwrite', filename, variables, metadata);
writer = arrow.internal.io.feather.Writer(filename);
writer.write(t);
end
11 changes: 5 additions & 6 deletions matlab/test/tfeather.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ function ErrorIfInvalidFilenameDatatype(testCase)

t = createTable;

testCase.verifyError(@() featherwrite({filename}, t), 'MATLAB:arrow:InvalidFilenameDatatype');
testCase.verifyError(@() featherwrite({table}, t), 'MATLAB:validation:UnableToConvert');
testCase.verifyError(@() featherread({filename}), 'MATLAB:arrow:InvalidFilenameDatatype');
end

Expand All @@ -178,7 +178,7 @@ function ErrorIfTooManyInputs(testCase)
end

function ErrorIfTooFewInputs(testCase)
testCase.verifyError(@() featherwrite(), 'MATLAB:narginchk:notEnoughInputs');
testCase.verifyError(@() featherwrite(), 'MATLAB:minrhs');
testCase.verifyError(@() featherread(), 'MATLAB:narginchk:notEnoughInputs');
end

Expand All @@ -193,7 +193,7 @@ function ErrorIfMultiColVarExist(testCase)

t = table(age, smoker, height, weight, bloodPressure);

testCase.verifyError(@() featherwrite(filename, t), 'MATLAB:arrow:UnsupportedVariableType');
testCase.verifyError(@() featherwrite(filename, t), 'arrow:array:InvalidShape');
end

function UnsupportedMATLABDatatypes(testCase)
Expand All @@ -205,7 +205,7 @@ function UnsupportedMATLABDatatypes(testCase)
calendarDuration(5, 3, 2)];
actualTable = addvars(actualTable, calendarDurationVariable);

testCase.verifyError(@() featherwrite(filename, actualTable) ,'MATLAB:arrow:UnsupportedVariableType');
testCase.verifyError(@() featherwrite(filename, actualTable) ,'arrow:array:UnsupportedMATLABType');
end

function NumericComplexUnsupported(testCase)
Expand All @@ -216,8 +216,7 @@ function NumericComplexUnsupported(testCase)
actualTable.double(2) = exp(9) + 5i;
actualTable.int64(2) = 1.0418e+03;

expectedTable = featherRoundTrip(filename, actualTable);
testCase.verifyNotEqual(actualTable, expectedTable);
testCase.verifyError(@() featherwrite(filename, actualTable) ,'arrow:array:ComplexNumeric');
end
end
end