ARROW-534: [C++] Add IPC tests for date/time after ARROW-452, fix bugs #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e. Fix bugs Change-Id: I31644429fdb93f1a9736f8dd9d4d7b322842eb81
xhochy
approved these changes
Mar 12, 2017
| Status Visit(const DoubleArray& array) override { | ||
| return VisitFixedWidth<DoubleArray>(array); | ||
| } | ||
| #define VISIT_FIXED_WIDTH(TYPE) \ |
Member
There was a problem hiding this comment.
Just a sidenote: When someone has a minute, we should think of how we could do this using std::enable_if instead of macros. I expect this to be much more compact.
jeffknupp
pushed a commit
to jeffknupp/arrow
that referenced
this pull request
Mar 15, 2017
Closes apache#345. I had mostly done this in apache#361 so this adds tests to `ipc-adapter-test` Author: Wes McKinney <wes.mckinney@twosigma.com> Closes apache#371 from wesm/ARROW-534 and squashes the following commits: cab6d4f [Wes McKinney] Add functions to make record batches for date, date32, timestamp, time. Fix bugs
wesm
pushed a commit
to wesm/arrow
that referenced
this pull request
Sep 8, 2018
Closes apache#356 cc @c-nichols Author: Colin Nichols <nichols01@gmail.com> Author: Uwe L. Korn <uwe@apache.org> Closes apache#371 from xhochy/PARQUET-1035 and squashes the following commits: 20e28e3 [Uwe L. Korn] Make support for INT96 optional dd197fc [Colin Nichols] Move timestamp conversion function to header file dfc9a00 [Colin Nichols] PARQUET-1035 Write Int96 from Arrow timestamp(ns) Change-Id: If190b59754f6b04762d223371b23b9229edaa216
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #345. I had mostly done this in #361 so this adds tests to
ipc-adapter-test