Skip to content

GH-36969: [R] Disable GCS by default when doing a bundled build on gcc-13 #37147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
assignUser merged 8 commits into from
Aug 16, 2023
Merged

GH-36969: [R] Disable GCS by default when doing a bundled build on gcc-13 #37147

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3841a76
give it a go
paleolimbot Aug 14, 2023
b9c41ff
maybe fix
paleolimbot Aug 14, 2023
b59798b
check version
paleolimbot Aug 14, 2023
095621b
maybe with the right env var name
paleolimbot Aug 14, 2023
34657f2
maybe better test
paleolimbot Aug 14, 2023
e97e7d3
fix another env var reference
paleolimbot Aug 14, 2023
8dab7ff
swallow more output
paleolimbot Aug 14, 2023
30cbe9e
fix check
paleolimbot Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions r/configure
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,21 @@ if [ ! "`${R_HOME}/bin/R CMD config CXX17`" ]; then
exit 1
fi

# GH-36969: The version of Abseil used in the bundled build won't build on
# gcc-13. As a workaround for the 13.0.0 release, explicitly set
# ARROW_WITH_GOOGLE_CLOUD_CPP to OFF (if not already set)
if [ -z "$ARROW_GCS" ]; then
CXX17=`${R_HOME}/bin/R CMD config CXX17`
CXX17_VERSION=`$CXX17 --version`
if echo "$CXX17_VERSION" | grep -e "g++" > /dev/null ; then
if echo "$CXX17_VERSION" | grep -e "13.[0-9]\+.[0-9]\+" > /dev/null ; then
echo "*** Disabling Arrow build with GCS on gcc-13."
echo "*** Set ARROW_GCS=ON to explicitly enable."
export ARROW_GCS="OFF"
fi
fi
fi

# Test if pkg-config is available to use
if ${PKG_CONFIG} --version >/dev/null 2>&1; then
PKG_CONFIG_AVAILABLE="true"
Expand Down