Skip to content

GH-37303: [Python] Update test_option_class_equality due to CumulativeSumOptions refactor #37305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jorisvandenbossche merged 1 commit into from
Aug 23, 2023
Merged

GH-37303: [Python] Update test_option_class_equality due to CumulativeSumOptions refactor #37305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions python/pyarrow/tests/test_compute.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,9 @@ def test_exported_option_classes():
param.VAR_KEYWORD)


@pytest.mark.filterwarnings(
"ignore:pyarrow.CumulativeSumOptions is deprecated as of 14.0"
)
def test_option_class_equality():
options = [
pc.ArraySortOptions(),
Expand Down Expand Up @@ -210,8 +213,8 @@ def test_option_class_equality():
buf = option.serialize()
deserialized = pc.FunctionOptions.deserialize(buf)
assert option == deserialized
# TODO remove the check under the if statement
# when the deprecated class CumulativeSumOptions is removed.
# TODO remove the check under the if statement and the filterwarnings
# mark when the deprecated class CumulativeSumOptions is removed.
if repr(option).startswith("CumulativeSumOptions"):
assert repr(deserialized).startswith("CumulativeOptions")
else:
Expand Down