GH-37386: [R] CRAN failures due to "invalid non-character version specification" #37387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
See also #37385 for the checks which will catch this in future |
github-actions
bot
added
Component: R
awaiting committer review
44 tasks
paleolimbot
approved these changes
Aug 25, 2023
github-actions
bot
added
awaiting merge
thisisnic
added a commit
to thisisnic/arrow
that referenced
this pull request
Aug 25, 2023
…on specification" (apache#37387) ### Rationale for this change Package version comparison results in CRAN checks failing due to values being numeric not character ### What changes are included in this PR? Changing numeric values to characters ### Are these changes tested? No ### Are there any user-facing changes? No * Closes: apache#37386 Authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 45c60ee. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…on specification" (apache#37387) ### Rationale for this change Package version comparison results in CRAN checks failing due to values being numeric not character ### What changes are included in this PR? Changing numeric values to characters ### Are these changes tested? No ### Are there any user-facing changes? No * Closes: apache#37386 Authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Nic Crane <thisisnic@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Package version comparison results in CRAN checks failing due to values being numeric not character
What changes are included in this PR?
Changing numeric values to characters
Are these changes tested?
No
Are there any user-facing changes?
No