GH-37485: [C++][Skyhook] Don't use deprecated BufferReader API #37486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: C++
awaiting committer review
mapleFU
approved these changes
Aug 31, 2023
Member
Author
|
@github-actions crossbow submit test-skyhook-integration |
|
Revision: 8a89cc6 Submitted crossbow builds: ursacomputing/crossbow @ actions-89548e38e7
|
pitrou
approved these changes
Aug 31, 2023
Member
|
CI looks unrelated, will merge. Thanks @kou ! |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit e8c39fb. There were 5 benchmark results indicating a performance regression:
The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…pache#37486) ### Rationale for this change apacheGH-37360 deprecated `BufferReader(const uint8_t*, int64_t)`. ### What changes are included in this PR? Use `BufferReader(std::shared_ptr<Buffer>)` instead. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#37485 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…pache#37486) ### Rationale for this change apacheGH-37360 deprecated `BufferReader(const uint8_t*, int64_t)`. ### What changes are included in this PR? Use `BufferReader(std::shared_ptr<Buffer>)` instead. ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#37485 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
GH-37360 deprecated
BufferReader(const uint8_t*, int64_t).What changes are included in this PR?
Use
BufferReader(std::shared_ptr<Buffer>)instead.Are these changes tested?
Yes.
Are there any user-facing changes?
No.