GH-38057: [Python][CI] Fix flaky hypothesis tests #38058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Member
Author
|
@github-actions crossbow submit test-conda-python-3.11-hypothesis |
|
Revision: 9b6e1d5 Submitted crossbow builds: ursacomputing/crossbow @ actions-6d93c05afe
|
jorisvandenbossche
approved these changes
Oct 5, 2023
Member
jorisvandenbossche
left a comment
jorisvandenbossche
left a comment
There was a problem hiding this comment.
Looks good, thanks!
github-actions
bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit bcbc707. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
### Rationale for this change Some hypothesis tests are consistently flaky due to taking too long to generate examples. "Too long" is ~2 seconds so let's just suppress the warnings. It is suppressed only for a small number of tests. ### What changes are included in this PR? * Suppress hypothesis warnings for test data generation being too slow (> 2 seconds). ### Are these changes tested? Will test the hypothesis CI job here. ### Are there any user-facing changes? No * Closes: apache#38057 Authored-by: Dane Pitkin <dane@voltrondata.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
### Rationale for this change Some hypothesis tests are consistently flaky due to taking too long to generate examples. "Too long" is ~2 seconds so let's just suppress the warnings. It is suppressed only for a small number of tests. ### What changes are included in this PR? * Suppress hypothesis warnings for test data generation being too slow (> 2 seconds). ### Are these changes tested? Will test the hypothesis CI job here. ### Are there any user-facing changes? No * Closes: apache#38057 Authored-by: Dane Pitkin <dane@voltrondata.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Some hypothesis tests are consistently flaky due to taking too long to generate examples. "Too long" is ~2 seconds so let's just suppress the warnings. It is suppressed only for a small number of tests.
What changes are included in this PR?
Are these changes tested?
Will test the hypothesis CI job here.
Are there any user-facing changes?
No