GH-38022: [Java][FlightRPC] Expose app_metadata on FlightInfo and FlightEndpoint

[aiguofer]

Making necessary changes in Java to expose the newly added app_metadata.

• Closes: [Java][FlightRPC] Expose app_metadata for FlightInfo and FlightEndpoint #38022

[github-actions]

⚠️ GitHub issue #38022 has been automatically assigned in GitHub to PR creator.

[aiguofer]

Should I add a constructor for FlightEndpoint(Ticket ticket, String appMetadata, Location... locations)?

[lidavidm]

We can omit that. A builder could be added.

[aiguofer]

Changed to private and added builder.

[lidavidm]

We can omit that. A builder could be added.

[lidavidm]

Thanks!

[lidavidm]

You'll want to rebase again, also unskip Java here:

arrow/dev/archery/archery/integration/runner.py

Lines 615 to 619 in 6f8f34b

	Scenario(
	"app_metadata_flight_info_endpoint",
	description="Ensure support FlightInfo and Endpoint app_metadata",
	skip_testers={"JS", "C#", "Rust", "Java"}
	),

[lidavidm]

Ah, sorry - then you need to implement the integration test scenario for Java to do the same thing as Go/C++: add an AppMetadataFlightInfoEndpointScenario.java at https://github.com/apache/arrow/tree/main/java/flight/flight-integration-tests/src/main/java/org/apache/arrow/flight/integration/tests following appMetadataFlightInfoEndpointScenarioTester in Go (

arrow/go/arrow/internal/flight_integration/scenario.go

Line 1241 in 5b9f4b9

type appMetadataFlightInfoEndpointScenarioTester struct {

)

[aiguofer]

No worries! Started on this but the java setup is quite different.

For the Producer, should I extend IntegrationProducer or NoOpFlightProducer? I've seen instances of both (and then there's FlightSqlScenarioProducer which implements the whole thing).

[lidavidm]

Start with NoOpFlightProducer here. IntegrationProducer should probably be renamed since it's specific to the roundtrip integration tests

[aiguofer]

Something interesting I noticed from the Go test... the Ticket on the FlightEndpoint can be null? Should I change the builder to accommodate (make another builder method taking only a potential list of endpoints).

[lidavidm]

the Ticket on the FlightEndpoint can be null

It's Protobuf, so any field can be omitted, but this is the same as having a ticket whose value is an empty string. I don't think we need to expose this separately in other languages.

[lidavidm]

Thank you!

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 57f643c.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 3 possible false positives for unstable benchmarks that are known to sometimes produce them.