GH-38401: [C++] Re-generate flatbuffers C++ for Skyhook#38405
Merged
kou merged 1 commit intoapache:mainfrom Oct 23, 2023
Merged
GH-38401: [C++] Re-generate flatbuffers C++ for Skyhook#38405kou merged 1 commit intoapache:mainfrom
kou merged 1 commit intoapache:mainfrom
Conversation
felipecrv
changed the title
felipecrv
changed the title
Contributor
Author
bkietz
approved these changes
Oct 23, 2023
github-actions
Bot
added
awaiting merge
felipecrv
force-pushed
the
skyhook_fix
branch
from
7c30435 to
74ba684
Compare
Contributor
Author
|
@bkietz I rebased to try to make the unrelated CI failures go awya. |
Contributor
Author
|
@raulcd should this be cherry picked into the release branch as well? |
kou
changed the title
Member
|
@github-actions crossbow submit test-skyhook-integration |
|
Revision: 74ba684 Submitted crossbow builds: ursacomputing/crossbow @ actions-472fa01af4
|
Member
|
#38192 isn't included in 14.0.0. So we don't need to cherry pick this to 14.0.0. |
|
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit be175de. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…#38405) ### Rationale for this change Vendored flatbuffer headers have been upgraded so the checked-in flatc-generated files need to be upgraded. ### What changes are included in this PR? - Changes to the shell script that re-generates flatbuffers - Check-in of the newly generated `ScanRequest_generated.h` ### Are these changes tested? By integration tests. * Closes: apache#38401 Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…#38405) ### Rationale for this change Vendored flatbuffer headers have been upgraded so the checked-in flatc-generated files need to be upgraded. ### What changes are included in this PR? - Changes to the shell script that re-generates flatbuffers - Check-in of the newly generated `ScanRequest_generated.h` ### Are these changes tested? By integration tests. * Closes: apache#38401 Authored-by: Felipe Oliveira Carvalho <felipekde@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Vendored flatbuffer headers have been upgraded so the checked-in flatc-generated files need to be upgraded.
What changes are included in this PR?
ScanRequest_generated.hAre these changes tested?
By integration tests.